From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0B27C169C4 for ; Tue, 29 Jan 2019 18:10:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 998AD21848 for ; Tue, 29 Jan 2019 18:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728622AbfA2SK0 (ORCPT ); Tue, 29 Jan 2019 13:10:26 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:33648 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726846AbfA2SK0 (ORCPT ); Tue, 29 Jan 2019 13:10:26 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5824814EFB5BC; Tue, 29 Jan 2019 10:10:25 -0800 (PST) Date: Tue, 29 Jan 2019 10:10:24 -0800 (PST) Message-Id: <20190129.101024.2142969510882311385.davem@davemloft.net> To: mika.westerberg@linux.intel.com Cc: linux-kernel@vger.kernel.org, michael.jamet@intel.com, YehezkelShB@gmail.com, andreas.noever@gmail.com, lukas@wunner.de, andriy.shevchenko@linux.intel.com, netdev@vger.kernel.org Subject: Re: [PATCH 01/28] net: thunderbolt: Unregister ThunderboltIP protocol handler when suspending From: David Miller In-Reply-To: <20190129150143.12681-2-mika.westerberg@linux.intel.com> References: <20190129150143.12681-1-mika.westerberg@linux.intel.com> <20190129150143.12681-2-mika.westerberg@linux.intel.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Jan 2019 10:10:25 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mika Westerberg Date: Tue, 29 Jan 2019 18:01:16 +0300 > The XDomain protocol messages may start as soon as Thunderbolt control > channel is started. This means that if the other host starts sending > ThunderboltIP packets early enough they will be passed to the network > driver which then gets confused because its resume hook is not called > yet. > > Fix this by unregistering the ThunderboltIP protocol handler when > suspending and registering it back on resume. > > Signed-off-by: Mika Westerberg Acked-by: David S. Miller