From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events
Date: Tue, 29 Jan 2019 10:04:38 +0100 [thread overview]
Message-ID: <20190129090438.GA30190@krava> (raw)
In-Reply-To: <20190129084851.GC4344@kernel.org>
On Tue, Jan 29, 2019 at 09:48:51AM +0100, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jan 28, 2019 at 09:00:37AM -0800, Andi Kleen escreveu:
> > > > also now it won't make sample for slave events
> > > > with zero value/period read
> > > >
> > > > note the patch needs to be split into more patches,
> > > > sending it all together for discussion over the solution
> > >
> > > any feedback on this one?
> >
> > Looks good to me.
> >
> > Reviewed-by: Andi Kleen <ak@linux.intel.com>
> > -Andi
>
> Jiri, can you repost with a proper Subject line, Andi's reviewed-by,
> etc?
yes, I need to separate that change also.. just wanted
some ack on the output ;-)
jirka
next prev parent reply other threads:[~2019-01-29 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 19:48 [PATCH] perf, script: Fix crash with printing mixed trace point and other events Andi Kleen
2019-01-18 9:49 ` Jiri Olsa
2019-01-18 12:59 ` Arnaldo Carvalho de Melo
2019-01-18 13:01 ` Arnaldo Carvalho de Melo
2019-01-18 13:42 ` [RFC] Don't print sample_type bits in non-group events not set in the group's was " Arnaldo Carvalho de Melo
2019-01-18 16:10 ` Jiri Olsa
2019-01-18 16:11 ` Andi Kleen
2019-01-18 16:17 ` Jiri Olsa
2019-01-19 15:37 ` Jiri Olsa
2019-01-28 14:13 ` Jiri Olsa
2019-01-28 17:00 ` Andi Kleen
2019-01-29 8:48 ` Arnaldo Carvalho de Melo
2019-01-29 9:04 ` Jiri Olsa [this message]
2019-01-22 11:34 ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129090438.GA30190@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).