From: Oscar Salvador <osalvador@suse.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: Mikhail Zaslonko <zaslonko@linux.ibm.com>,
Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
gerald.schaefer@de.ibm.com, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 2/2] mm, memory_hotplug: test_pages_in_a_zone do not pass the end of zone
Date: Tue, 29 Jan 2019 10:09:08 +0100 [thread overview]
Message-ID: <20190129090908.oms43oyjicozkvzu@d104.suse.de> (raw)
In-Reply-To: <20190128144506.15603-3-mhocko@kernel.org>
On Mon, Jan 28, 2019 at 03:45:06PM +0100, Michal Hocko wrote:
> From: Mikhail Zaslonko <zaslonko@linux.ibm.com>
>
> If memory end is not aligned with the sparse memory section boundary, the
> mapping of such a section is only partly initialized. This may lead to
> VM_BUG_ON due to uninitialized struct pages access from test_pages_in_a_zone()
> function triggered by memory_hotplug sysfs handlers.
>
> Here are the the panic examples:
> CONFIG_DEBUG_VM_PGFLAGS=y
> kernel parameter mem=2050M
> --------------------------
> page:000003d082008000 is uninitialized and poisoned
> page dumped because: VM_BUG_ON_PAGE(PagePoisoned(p))
> Call Trace:
> ([<0000000000385b26>] test_pages_in_a_zone+0xde/0x160)
> [<00000000008f15c4>] show_valid_zones+0x5c/0x190
> [<00000000008cf9c4>] dev_attr_show+0x34/0x70
> [<0000000000463ad0>] sysfs_kf_seq_show+0xc8/0x148
> [<00000000003e4194>] seq_read+0x204/0x480
> [<00000000003b53ea>] __vfs_read+0x32/0x178
> [<00000000003b55b2>] vfs_read+0x82/0x138
> [<00000000003b5be2>] ksys_read+0x5a/0xb0
> [<0000000000b86ba0>] system_call+0xdc/0x2d8
> Last Breaking-Event-Address:
> [<0000000000385b26>] test_pages_in_a_zone+0xde/0x160
> Kernel panic - not syncing: Fatal exception: panic_on_oops
>
> Fix this by checking whether the pfn to check is within the zone.
>
> [mhocko@suse.com: separated this change from
> http://lkml.kernel.org/r/20181105150401.97287-2-zaslonko@linux.ibm.com]
> Signed-off-by: Mikhail Zaslonko <zaslonko@linux.ibm.com>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Looks good to me:
Reviewed-by: Oscar Salvador <osalvador@suse.de>
> ---
> mm/memory_hotplug.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 07872789d778..7711d0e327b6 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1274,6 +1274,9 @@ int test_pages_in_a_zone(unsigned long start_pfn, unsigned long end_pfn,
> i++;
> if (i == MAX_ORDER_NR_PAGES || pfn + i >= end_pfn)
> continue;
> + /* Check if we got outside of the zone */
> + if (zone && !zone_spans_pfn(zone, pfn + i))
> + return 0;
> page = pfn_to_page(pfn + i);
Since we are already checking if the zone spans that pfn, is it safe to get
rid of the below check? Or maybe not because we might have intersected zones?
> if (zone && page_zone(page) != zone)
> return 0;
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2019-01-29 9:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 14:45 [PATCH 0/2] mm, memory_hotplug: fix uninitialized pages fallouts Michal Hocko
2019-01-28 14:45 ` [PATCH 1/2] mm, memory_hotplug: is_mem_section_removable do not pass the end of a zone Michal Hocko
2019-01-29 9:06 ` Oscar Salvador
2019-01-29 9:12 ` Michal Hocko
2019-01-30 7:54 ` Oscar Salvador
2019-01-28 14:45 ` [PATCH 2/2] mm, memory_hotplug: test_pages_in_a_zone do not pass the end of zone Michal Hocko
2019-01-29 9:09 ` Oscar Salvador [this message]
2019-01-29 9:13 ` Michal Hocko
2019-01-28 17:50 ` [PATCH 0/2] mm, memory_hotplug: fix uninitialized pages fallouts Andrew Morton
2019-01-28 18:41 ` Michal Hocko
2019-01-28 18:45 ` Michal Hocko
2019-01-29 13:14 ` Gerald Schaefer
2019-01-29 13:49 ` Michal Hocko
2019-01-29 14:08 ` Gerald Schaefer
2019-01-29 17:38 ` Mikhail Gavrilov
2019-01-29 20:24 ` Michal Hocko
2019-01-29 20:56 ` Mikhail Gavrilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129090908.oms43oyjicozkvzu@d104.suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=gerald.schaefer@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=mikhail.v.gavrilov@gmail.com \
--cc=pasha.tatashin@soleen.com \
--cc=schwidefsky@de.ibm.com \
--cc=zaslonko@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).