From: Joerg Roedel <jroedel@suse.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Daniel Vetter <daniel@ffwll.ch>, Lukas Wunner <lukas@wunner.de>,
Andrzej Hajda <a.hajda@samsung.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Lucas Stach <l.stach@pengutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>
Subject: Re: [PATCH 1/4] IOMMU: Make dwo drivers use stateless device links
Date: Tue, 29 Jan 2019 10:17:33 +0100 [thread overview]
Message-ID: <20190129091733.3ue6ifr3tpwu237j@suse.de> (raw)
In-Reply-To: <3532356.d9GMSSLOvP@aspire.rjw.lan>
On Tue, Jan 29, 2019 at 12:05:21AM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The device links used by rockchip-iommu and exynos-iommu are
> completely managed by these drivers within the IOMMU framework,
> so there is no reason to involve the driver core in the management
> of these links.
>
> For this reason, make rockchip-iommu and exynos-iommu pass
> DL_FLAG_STATELESS in flags to device_link_add(), so that the device
> links used by them are stateless.
>
> [Note that this change is requisite for a subsequent one that will
> rework the management of stateful device links in the driver core
> and it will not be compatible with the two drivers in question any
> more.]
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/iommu/exynos-iommu.c | 1 +
> drivers/iommu/rockchip-iommu.c | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
Acked-by: Joerg Roedel <jroedel@suse.de>
>
> Index: linux-pm/drivers/iommu/rockchip-iommu.c
> ===================================================================
> --- linux-pm.orig/drivers/iommu/rockchip-iommu.c
> +++ linux-pm/drivers/iommu/rockchip-iommu.c
> @@ -1071,7 +1071,8 @@ static int rk_iommu_add_device(struct de
> iommu_group_put(group);
>
> iommu_device_link(&iommu->iommu, dev);
> - data->link = device_link_add(dev, iommu->dev, DL_FLAG_PM_RUNTIME);
> + data->link = device_link_add(dev, iommu->dev,
> + DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME);
>
> return 0;
> }
> Index: linux-pm/drivers/iommu/exynos-iommu.c
> ===================================================================
> --- linux-pm.orig/drivers/iommu/exynos-iommu.c
> +++ linux-pm/drivers/iommu/exynos-iommu.c
> @@ -1260,6 +1260,7 @@ static int exynos_iommu_add_device(struc
> * direct calls to pm_runtime_get/put in this driver.
> */
> data->link = device_link_add(dev, data->sysmmu,
> + DL_FLAG_STATELESS |
> DL_FLAG_PM_RUNTIME);
> }
> iommu_group_put(group);
next prev parent reply other threads:[~2019-01-29 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 23:03 [PATCH 0/4] driver core: Managed device links rework and "consumer autoprobe" flag Rafael J. Wysocki
2019-01-28 23:05 ` [PATCH 1/4] IOMMU: Make dwo drivers use stateless device links Rafael J. Wysocki
2019-01-29 8:55 ` Marek Szyprowski
2019-01-29 9:17 ` Joerg Roedel [this message]
2019-01-28 23:06 ` [PATCH 2/4] driver core: Make driver core own stateful " Rafael J. Wysocki
2019-01-28 23:07 ` [PATCH 3/4] driver core: Add device link flag DL_FLAG_AUTOPROBE_CONSUMER Rafael J. Wysocki
2019-01-28 23:08 ` [PATCH 4/4] driver core: Do not call rpm_put_suppliers() in pm_runtime_drop_link() Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129091733.3ue6ifr3tpwu237j@suse.de \
--to=jroedel@suse.de \
--cc=a.hajda@samsung.com \
--cc=daniel@ffwll.ch \
--cc=gregkh@linuxfoundation.org \
--cc=jeffy.chen@rock-chips.com \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas@wunner.de \
--cc=m.szyprowski@samsung.com \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).