From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3228C169C4 for ; Tue, 29 Jan 2019 10:24:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D18321473 for ; Tue, 29 Jan 2019 10:24:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728397AbfA2KYS (ORCPT ); Tue, 29 Jan 2019 05:24:18 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33070 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726971AbfA2KYR (ORCPT ); Tue, 29 Jan 2019 05:24:17 -0500 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0TANm0D105942 for ; Tue, 29 Jan 2019 05:24:16 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2qakp0n5d5-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 29 Jan 2019 05:24:15 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 29 Jan 2019 10:24:14 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 29 Jan 2019 10:24:12 -0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x0TAOBHN46989524 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 29 Jan 2019 10:24:11 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 45F0A42054; Tue, 29 Jan 2019 10:24:11 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EEA8B4203F; Tue, 29 Jan 2019 10:24:10 +0000 (GMT) Received: from osiris (unknown [9.152.212.95]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 29 Jan 2019 10:24:10 +0000 (GMT) Date: Tue, 29 Jan 2019 11:24:09 +0100 From: Heiko Carstens To: Thomas Gleixner Cc: Peter Zijlstra , Ingo Molnar , Martin Schwidefsky , LKML , linux-s390@vger.kernel.org, Stefan Liebler , Sebastian Sewior Subject: Re: WARN_ON_ONCE(!new_owner) within wake_futex_pi() triggered References: <20181127081115.GB3625@osiris> <20181129112321.GB3449@osiris> <20190128134410.GA28485@hirez.programming.kicks-ass.net> <20190128135804.GB28878@hirez.programming.kicks-ass.net> <20190129090108.GA26906@osiris> MIME-Version: 1.0 In-Reply-To: X-TM-AS-GCONF: 00 x-cbid: 19012910-0020-0000-0000-0000030D3DF7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19012910-0021-0000-0000-0000215E40D6 Message-Id: <20190129102409.GB26906@osiris> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-29_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901290080 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 29, 2019 at 10:45:44AM +0100, Thomas Gleixner wrote: > On Tue, 29 Jan 2019, Heiko Carstens wrote: > > On Mon, Jan 28, 2019 at 04:53:19PM +0100, Thomas Gleixner wrote: > > > Patch below cures that. > > > > With your patch the kernel warning doesn't occur anymore. So if this > > is supposed to be the fix feel free to add: > > Yes, it's supposed to be the fix. > > > > However now I see every now and then the following failure from the > > same test case: > > > > tst-robustpi8: ../nptl/pthread_mutex_lock.c:425: __pthread_mutex_lock_full: Assertion `INTERNAL_SYSCALL_ERRNO (e, __err) != ESRCH || !robust' failed. > > > > /* ESRCH can happen only for non-robust PI mutexes where > > the owner of the lock died. */ > > assert (INTERNAL_SYSCALL_ERRNO (e, __err) != ESRCH || !robust); > > > > I just verified that this happened also without your patch, I just > > didn't see it since I started my tests with panic_on_warn=1 and the > > warning triggered always earlier. > > So, this seems to be something different. > > Moo. I ran the test loop all night (simply because I forgot to stop it) and > of course this does not trigger here. Could you try to gather a bit more > information with lightweight tracing? Yes, sure. However ;) I reproduced the above with v5.0-rc4 + your patch. And now I am trying to reproduce with linux-next 20190129 + your patch and it doesn't trigger. Did I miss a patch which is only in linux-next which could fix this?