From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B5E8C169C4 for ; Tue, 29 Jan 2019 11:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1341214DA for ; Tue, 29 Jan 2019 11:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548762309; bh=fH6EZICqN5S9q4EwZTZ+g/ldN/sjjJrxzE5DJBKtHWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=VUa4xAc+iJwGnXVqrb43zjws6pcZteK7kInE27JjPJgHW2UHZ12BtF9DQ3Ig1TtG0 OXQ6dYY3lIyR/gxuDpGKfMtNvPRMGVAUQaGHEvyRHWi4vFDu5kXKL3GbS6Tu6NFZpE 5EFUltALjurDNvU28Q1VA2gkozlYV3yZOJQd1XJQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729886AbfA2LpH (ORCPT ); Tue, 29 Jan 2019 06:45:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:35556 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730024AbfA2LpG (ORCPT ); Tue, 29 Jan 2019 06:45:06 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D4502083B; Tue, 29 Jan 2019 11:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548762306; bh=fH6EZICqN5S9q4EwZTZ+g/ldN/sjjJrxzE5DJBKtHWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bM/g6CVkUpVgAx14mJ7+VSSWj6uzaM57VeWxU8HQySBfaDD5HWPedCIVI1d77V/Sz pm6fJx4unRnTVA7gL2TFGRP2GSF9U2GTPwtTg8U7U1ihH25jqA9AIYImHmTw37vwWP dmYlMptBUrXGSv8J+psoPqeeTC7B9C1xr6cqJKt0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , Pierre-Louis Bossart , Mark Brown Subject: [PATCH 4.19 028/103] ASoC: atom: fix a missing check of snd_pcm_lib_malloc_pages Date: Tue, 29 Jan 2019 12:35:05 +0100 Message-Id: <20190129113201.270555094@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190129113159.567154026@linuxfoundation.org> References: <20190129113159.567154026@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kangjie Lu commit 44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661 upstream. snd_pcm_lib_malloc_pages() may fail, so let's check its status and return its error code upstream. Signed-off-by: Kangjie Lu Acked-by: Pierre-Louis Bossart Signed-off-by: Mark Brown Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c @@ -399,7 +399,13 @@ static int sst_media_hw_params(struct sn struct snd_pcm_hw_params *params, struct snd_soc_dai *dai) { - snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(params)); + int ret; + + ret = + snd_pcm_lib_malloc_pages(substream, + params_buffer_bytes(params)); + if (ret) + return ret; memset(substream->runtime->dma_area, 0, params_buffer_bytes(params)); return 0; }