From: Masayoshi Mizuma <msys.mizuma@gmail.com>
To: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Cc: Masayoshi Mizuma <msys.mizuma@gmail.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Joe Lawrence <joe.lawrence@redhat.com>
Subject: [PATCH] sched/debug: initialize sd_sysctl_cpus if !CONFIG_CPUMASK_OFFSTACK
Date: Tue, 29 Jan 2019 10:12:45 -0500 [thread overview]
Message-ID: <20190129151245.5073-1-msys.mizuma@gmail.com> (raw)
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
register_sched_domain_sysctl() copies the cpu_possible_mask into
sd_sysctl_cpus, but only if sd_sysctl_cpus hasn't already been
allocated (ie, CONFIG_CPUMASK_OFFSTACK is set). However, when
CONFIG_CPUMASK_OFFSTACK is not set, sd_sysctl_cpus is left uninitialized
(all zeroes) and the kernel may fail to initialize sched_domain sysctl
entries for all possible cpus.
This is visible to the user if the kernel is booted with maxcpus=n, or
if ACPI tables have been modified to leave cpus offline, and then
checking for missing /proc/sys/kernel/sched_domain/cpu* entries.
Fix this by separating the allocataion and initialization, and adding
a flag to initialize the possible cpu entries while system booting only.
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Reviewed-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Tested-by: Syuuichirou Ishii <ishii.shuuichir@jp.fujitsu.com>
Tested-by: Tarumizu, Kohei <tarumizu.kohei@jp.fujitsu.com>
---
kernel/sched/debug.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index de3de997e245..9c6637f3e21d 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -310,6 +310,7 @@ static struct ctl_table *sd_alloc_ctl_cpu_table(int cpu)
static cpumask_var_t sd_sysctl_cpus;
static struct ctl_table_header *sd_sysctl_header;
+static int register_sched_domain_sysctl_on_boot = 1;
void register_sched_domain_sysctl(void)
{
@@ -344,9 +345,12 @@ void register_sched_domain_sysctl(void)
if (!cpumask_available(sd_sysctl_cpus)) {
if (!alloc_cpumask_var(&sd_sysctl_cpus, GFP_KERNEL))
return;
+ }
+ if (register_sched_domain_sysctl_on_boot) {
/* init to possible to not have holes in @cpu_entries */
cpumask_copy(sd_sysctl_cpus, cpu_possible_mask);
+ register_sched_domain_sysctl_on_boot = 0;
}
for_each_cpu(i, sd_sysctl_cpus) {
--
2.20.1
next reply other threads:[~2019-01-29 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 15:12 Masayoshi Mizuma [this message]
2019-01-29 16:16 ` [PATCH] sched/debug: initialize sd_sysctl_cpus if !CONFIG_CPUMASK_OFFSTACK Joe Lawrence
2019-01-30 20:14 ` Peter Zijlstra
2019-01-31 13:44 ` Masayoshi Mizuma
2019-02-01 22:33 ` Joe Lawrence
2019-02-04 9:02 ` [tip:sched/core] sched/debug: Initialize " tip-bot for Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129151245.5073-1-msys.mizuma@gmail.com \
--to=msys.mizuma@gmail.com \
--cc=joe.lawrence@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).