From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2705DC169C4 for ; Tue, 29 Jan 2019 18:04:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8E312184D for ; Tue, 29 Jan 2019 18:04:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="KK/BmMBx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728696AbfA2SEd (ORCPT ); Tue, 29 Jan 2019 13:04:33 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:39626 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726314AbfA2SEc (ORCPT ); Tue, 29 Jan 2019 13:04:32 -0500 Received: by mail-qt1-f196.google.com with SMTP id u47so23259228qtj.6 for ; Tue, 29 Jan 2019 10:04:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cwEU7AT/ieVZmX0uniQzflMmYmVY27dwbxE28b4hY5o=; b=KK/BmMBxRo/7DcUUZt9q/dti8YEUhE3d/thibIQu8bV2rTQygTS0kCmrR7TQqsxjv/ IXFC15AMSLKeHoTT0comMRxaiJcn30X9+AZoBupPNRZJVnUVJaALfpvmO8M+ltcUZyCw JSc397vrxvhsI4FOMNo7qHuhFjQZkBYpQddKTWCHcZzYD8hEaU8EL+P/MR5V+UkWYzAV crc0b41dGGHQkS7ZeMAHvD0y9y7ZCr+CJajvUEEIQU4p/tHVhb+TVpSN8UVxe2d5Fuhv gip8uEvcGU50VFxBIzpqUaW+670MWeDvrUefxWZ+Yg+ZYui0ltaTad6tHsLjNDcGcMBl VLZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cwEU7AT/ieVZmX0uniQzflMmYmVY27dwbxE28b4hY5o=; b=JIt4Hq1Kek0Au7O0eAWhpiRbzZVcJ/AKiQpnty+syc66Vxn2j/zk8Dc62WLRAL46gd Z2p5yfWc8p0JpzMCWNi9SyAjmwaCp37JfE5JPfjVb9EHXZ7B793BufcWhBVdnaa6Oufv 4kjX4qLrT22J/1cl4neyvi4BJXBQJ6HS3dJZw2mWhl+8lCIgl7EoJ1XUR6FOaXDCM7jP JgWHikQfD1/eNOyu5/Aa+k9y0vs/zTniACyCX8kEv4f4p7KRubHBXLBnNhByCv5BNoHW GgXMLnPiTdZfBgfq1SrJVTs3Ltf6vt1kQBECbqCLj/QtE0CS0Vsv8nuy7Cuoql69U1uN vKqA== X-Gm-Message-State: AJcUukfXZ0cwO9+F5pWX5DoZcNvIEb+lFsDc8VaTMXkW05FQayQ958VJ hsR8DxN+FMohHpSFojOa/D2APQ== X-Google-Smtp-Source: ALg8bN6Zb6BV7j85r5PqzLkOoDoAArt1ZGj2iawq3cAEwna1LznWSuLXNoTHhTxh8cm29/d9GagqWQ== X-Received: by 2002:a0c:afd1:: with SMTP id t17mr25139029qvc.93.1548785072068; Tue, 29 Jan 2019 10:04:32 -0800 (PST) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id c7sm17856693qkj.72.2019.01.29.10.04.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 10:04:31 -0800 (PST) Date: Tue, 29 Jan 2019 13:04:30 -0500 From: Josef Bacik To: Dennis Zhou Cc: David Sterba , Josef Bacik , Chris Mason , Omar Sandoval , Nick Terrell , kernel-team@fb.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/11] btrfs: add helper methods for workspace manager init and cleanup Message-ID: <20190129180429.m7iwwrlnk2set6gl@MacBook-Pro-91.local> References: <20190128212437.11597-1-dennis@kernel.org> <20190128212437.11597-6-dennis@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190128212437.11597-6-dennis@kernel.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 28, 2019 at 04:24:31PM -0500, Dennis Zhou wrote: > Workspace manager init and cleanup code is open coded inside a for loop > over the compression types. This forces each compression type to rely on > the same workspace manager implementation. This patch creates helper > methods that will be the generic implementation for btrfs workspace > management. > > Signed-off-by: Dennis Zhou Reviewed-by: Josef Bacik Thanks, Josef