* [PATCH] mmc: atmel-mci: enable 8 bits buswidth support
@ 2019-01-29 16:49 Nicolas Ferre
2019-01-29 20:12 ` Alexandre Belloni
2019-01-30 9:20 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Ferre @ 2019-01-29 16:49 UTC (permalink / raw)
To: Ludovic Desroches
Cc: Nicolas Ferre, Ulf Hansson, Alexandre Belloni, linux-mmc,
linux-arm-kernel, linux-kernel
This patch adds support for 8-bit buswidth.
Relevant SDCR value modified.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
drivers/mmc/host/atmel-mci.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index 47189f9ed4e2..735aa5871358 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -1410,6 +1410,9 @@ static void atmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
case MMC_BUS_WIDTH_4:
slot->sdc_reg |= ATMCI_SDCBUS_4BIT;
break;
+ case MMC_BUS_WIDTH_8:
+ slot->sdc_reg |= ATMCI_SDCBUS_8BIT;
+ break;
}
if (ios->clock) {
@@ -2275,8 +2278,11 @@ static int atmci_init_slot(struct atmel_mci *host,
* use only one bit for data to prevent fifo underruns and overruns
* which will corrupt data.
*/
- if ((slot_data->bus_width >= 4) && host->caps.has_rwproof)
+ if ((slot_data->bus_width >= 4) && host->caps.has_rwproof) {
mmc->caps |= MMC_CAP_4_BIT_DATA;
+ if (slot_data->bus_width >= 8)
+ mmc->caps |= MMC_CAP_8_BIT_DATA;
+ }
if (atmci_get_version(host) < 0x200) {
mmc->max_segs = 256;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: atmel-mci: enable 8 bits buswidth support
2019-01-29 16:49 [PATCH] mmc: atmel-mci: enable 8 bits buswidth support Nicolas Ferre
@ 2019-01-29 20:12 ` Alexandre Belloni
2019-01-30 9:20 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2019-01-29 20:12 UTC (permalink / raw)
To: Nicolas Ferre
Cc: Ludovic Desroches, Ulf Hansson, linux-mmc, linux-arm-kernel,
linux-kernel
On 29/01/2019 17:49:12+0100, Nicolas Ferre wrote:
> This patch adds support for 8-bit buswidth.
> Relevant SDCR value modified.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/mmc/host/atmel-mci.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 47189f9ed4e2..735aa5871358 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -1410,6 +1410,9 @@ static void atmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> case MMC_BUS_WIDTH_4:
> slot->sdc_reg |= ATMCI_SDCBUS_4BIT;
> break;
> + case MMC_BUS_WIDTH_8:
> + slot->sdc_reg |= ATMCI_SDCBUS_8BIT;
> + break;
> }
>
> if (ios->clock) {
> @@ -2275,8 +2278,11 @@ static int atmci_init_slot(struct atmel_mci *host,
> * use only one bit for data to prevent fifo underruns and overruns
> * which will corrupt data.
> */
> - if ((slot_data->bus_width >= 4) && host->caps.has_rwproof)
> + if ((slot_data->bus_width >= 4) && host->caps.has_rwproof) {
> mmc->caps |= MMC_CAP_4_BIT_DATA;
> + if (slot_data->bus_width >= 8)
> + mmc->caps |= MMC_CAP_8_BIT_DATA;
> + }
>
> if (atmci_get_version(host) < 0x200) {
> mmc->max_segs = 256;
> --
> 2.17.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: atmel-mci: enable 8 bits buswidth support
2019-01-29 16:49 [PATCH] mmc: atmel-mci: enable 8 bits buswidth support Nicolas Ferre
2019-01-29 20:12 ` Alexandre Belloni
@ 2019-01-30 9:20 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2019-01-30 9:20 UTC (permalink / raw)
To: Nicolas Ferre
Cc: Ludovic Desroches, Alexandre Belloni, linux-mmc, Linux ARM,
Linux Kernel Mailing List
On Tue, 29 Jan 2019 at 17:50, Nicolas Ferre <nicolas.ferre@microchip.com> wrote:
>
> This patch adds support for 8-bit buswidth.
> Relevant SDCR value modified.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/atmel-mci.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 47189f9ed4e2..735aa5871358 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -1410,6 +1410,9 @@ static void atmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> case MMC_BUS_WIDTH_4:
> slot->sdc_reg |= ATMCI_SDCBUS_4BIT;
> break;
> + case MMC_BUS_WIDTH_8:
> + slot->sdc_reg |= ATMCI_SDCBUS_8BIT;
> + break;
> }
>
> if (ios->clock) {
> @@ -2275,8 +2278,11 @@ static int atmci_init_slot(struct atmel_mci *host,
> * use only one bit for data to prevent fifo underruns and overruns
> * which will corrupt data.
> */
> - if ((slot_data->bus_width >= 4) && host->caps.has_rwproof)
> + if ((slot_data->bus_width >= 4) && host->caps.has_rwproof) {
> mmc->caps |= MMC_CAP_4_BIT_DATA;
> + if (slot_data->bus_width >= 8)
> + mmc->caps |= MMC_CAP_8_BIT_DATA;
> + }
>
> if (atmci_get_version(host) < 0x200) {
> mmc->max_segs = 256;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-30 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 16:49 [PATCH] mmc: atmel-mci: enable 8 bits buswidth support Nicolas Ferre
2019-01-29 20:12 ` Alexandre Belloni
2019-01-30 9:20 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).