From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Govind Singh <govinds@codeaurora.org>,
Erik Stromdahl <erik.stromdahl@gmail.com>,
Wen Gong <wgong@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-5.0] ath10k: correct bus type for WCN3990
Date: Tue, 29 Jan 2019 22:10:59 -0800 [thread overview]
Message-ID: <20190130061059.GA2387@tuxbook-pro> (raw)
In-Reply-To: <20190129231201.42230-1-briannorris@chromium.org>
On Tue 29 Jan 15:12 PST 2019, Brian Norris wrote:
> WCN3990 is SNOC, not PCI. This prevents probing WCN3990.
>
> Fixes: 367c899f622c ("ath10k: add bus type check in ath10k_init_hw_params")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> This was a regression in 4.20.
>
> drivers/net/wireless/ath/ath10k/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index 399b501f3c3c..e8891f5fc83a 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -548,7 +548,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
> {
> .id = WCN3990_HW_1_0_DEV_VERSION,
> .dev_id = 0,
> - .bus = ATH10K_BUS_PCI,
> + .bus = ATH10K_BUS_SNOC,
> .name = "wcn3990 hw1.0",
> .continuous_frag_desc = true,
> .tx_chain_mask = 0x7,
> --
> 2.20.1.495.gaa96b0ce6b-goog
>
next prev parent reply other threads:[~2019-01-30 6:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 23:12 [PATCH for-5.0] ath10k: correct bus type for WCN3990 Brian Norris
2019-01-30 6:10 ` Bjorn Andersson [this message]
2019-01-30 10:11 ` Kalle Valo
2019-01-31 16:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130061059.GA2387@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=erik.stromdahl@gmail.com \
--cc=govinds@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).