From: Oscar Salvador <osalvador@suse.de>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
mhocko@suse.com
Subject: Re: [PATCH] mm,memory_hotplug: Fix scan_movable_pages for gigantic hugepages
Date: Wed, 30 Jan 2019 08:52:03 +0100 [thread overview]
Message-ID: <20190130075200.yauazwxy6s2xb7tr@d104.suse.de> (raw)
In-Reply-To: <33fdaa38-6204-bef0-b12f-0416f16dc165@redhat.com>
On Tue, Jan 29, 2019 at 11:03:56AM +0100, David Hildenbrand wrote:
> Not sure if encoding the -1 in the previous line is even better now that
> we have more space
>
> skip = (1 << compound_order(head)) - (page - head + 1);
>
> Looks good to me.
>
> > }
I would rather not do that.
For me looks a bit "subtle" why do we add up 1 after substracting page - head.
I think that doing "skip - 1" looks more clear, but I do not have a strong
opinion here.
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2019-01-30 7:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:44 [PATCH] mm,memory_hotplug: Fix scan_movable_pages for gigantic hugepages Oscar Salvador
2019-01-22 23:47 ` Anthony Yznaga
2019-01-23 9:47 ` Michal Hocko
2019-01-23 10:18 ` Oscar Salvador
2019-01-23 10:22 ` Michal Hocko
2019-01-23 10:33 ` David Hildenbrand
2019-01-25 7:58 ` Oscar Salvador
2019-01-28 22:53 ` Andrew Morton
2019-01-28 22:56 ` Andrew Morton
2019-01-29 7:33 ` Michal Hocko
2019-01-29 8:27 ` Oscar Salvador
2019-01-29 10:03 ` David Hildenbrand
2019-01-30 7:52 ` Oscar Salvador [this message]
2019-01-28 22:53 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130075200.yauazwxy6s2xb7tr@d104.suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).