From: Lee Jones <lee.jones@linaro.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: sm501: Fix potential NULL pointer dereference
Date: Wed, 30 Jan 2019 13:35:25 +0000 [thread overview]
Message-ID: <20190130133525.GG4701@dell> (raw)
In-Reply-To: <6376930a04650c2dafcbe306f6d402794c30d5b3.1548175934.git.gustavo@embeddedor.com>
On Tue, 22 Jan 2019, Gustavo A. R. Silva wrote:
> There is a potential NULL pointer dereference in case devm_kzalloc()
> fails and returns NULL.
>
> Fix this by adding a NULL check on *lookup*
>
> This bug was detected with the help of Coccinelle.
>
> Fixes: b2e63555592f ("i2c: gpio: Convert to use descriptors")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/mfd/sm501.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-01-30 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 16:55 [PATCH 0/2] Fix NULL pointer dereference and use struct_size() Gustavo A. R. Silva
2019-01-22 16:56 ` [PATCH 1/2] mfd: sm501: Fix potential NULL pointer dereference Gustavo A. R. Silva
2019-01-30 13:35 ` Lee Jones [this message]
2019-01-31 0:16 ` Gustavo A. R. Silva
2019-01-22 16:58 ` [PATCH 2/2] mfd: sm501: Use struct_size() in devm_kzalloc() Gustavo A. R. Silva
2019-01-30 13:35 ` Lee Jones
2019-01-26 13:20 ` [PATCH 0/2] Fix NULL pointer dereference and use struct_size() Linus Walleij
2019-01-26 13:49 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130133525.GG4701@dell \
--to=lee.jones@linaro.org \
--cc=gustavo@embeddedor.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).