From: Greg KH <gregkh@linuxfoundation.org>
To: Roman Kiryanov <rkir@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] drivers: platform: goldfish: goldfish_address_space: add a driver
Date: Wed, 30 Jan 2019 15:44:14 +0100 [thread overview]
Message-ID: <20190130144414.GA8357@kroah.com> (raw)
In-Reply-To: <CAOGAQeo1Kv55EUn2sYPOt9EgBMfN=+o_A4KOPVgqbJHo+HN-Sw@mail.gmail.com>
On Tue, Jan 29, 2019 at 12:32:12AM -0800, Roman Kiryanov wrote:
> > How does QEMU do this today? There isn't a virtio or some other virtual
> > memory device that allows memory regions to be shared? I can't believe
> > that there isn't one yet. If not, then this should be some kind of
> > "generic" QEMU memory device, not a "goldfish" specific one, right?
>
> I also thought this should not be something unique to us. So I asked
> in our internal mailing list, I heard nothing back.
>
> > Please work with the QEMU developers on this, I need their ack before I
> > can take something like this.
>
> This is a good point. I asked there (nothing since 1/24):
>
> http://lists.nongnu.org/archive/html/qemu-discuss/2019-01/msg00055.html
>
> When we were working on our device side, we had to change some QEMU
> code and later noticed that HAXM also requires some fixes (we had
> meetings with Intel). I suppose QEMU does not have this feature yet.
>
> Could you please tell if we can proceed with upstreaming as is?
Also, why does the other Android "emulator", cuttlefish, not need
special drivers like this and the other goldfish drivers? Shouldn't you
be using the same interfaces that they use that are already merged
upstream?
Actually, now that cuttlefish works on a mainline kernel, can't we just
delete the existing goldfish code?
thanks,
greg k-h
next prev parent reply other threads:[~2019-01-30 14:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 2:11 [PATCH v3 1/3] drivers: platform: goldfish: fix the checkpatch complain in Kconfig rkir
2019-01-09 2:11 ` [PATCH v3 2/3] drivers: platform: goldfish: goldfish_address_space: add a driver rkir
2019-01-09 8:31 ` Greg KH
2019-01-10 1:41 ` Roman Kiryanov
2019-01-16 4:53 ` Roman Kiryanov
2019-01-22 11:07 ` Greg KH
2019-01-29 8:32 ` Roman Kiryanov
2019-01-29 9:37 ` Greg KH
2019-01-30 14:44 ` Greg KH [this message]
2019-01-31 3:56 ` Roman Kiryanov
2019-01-09 2:11 ` [PATCH v3 3/3] drivers: platform: goldfish: goldfish_sync: " rkir
2019-01-22 11:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130144414.GA8357@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkir@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).