From: Johannes Weiner <hannes@cmpxchg.org>
To: Borislav Petkov <bp@suse.de>
Cc: Babu Moger <babu.moger@amd.com>,
linux-kernel@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] x86: avoid confusion over the new RESCTRL config prompt
Date: Wed, 30 Jan 2019 11:46:26 -0500 [thread overview]
Message-ID: <20190130164626.GA17841@cmpxchg.org> (raw)
In-Reply-To: <20190129230845.GG28773@zn.tnic>
On Wed, Jan 30, 2019 at 12:08:45AM +0100, Borislav Petkov wrote:
> On Tue, Jan 29, 2019 at 05:52:18PM -0500, Johannes Weiner wrote:
> > "Resource Control" is a very broad term for this CPU feature, and a
> > term that is also associated with containers, cgroups etc. This can
> > easily cause confusion.
> >
> > Make the user prompt more specific.
> >
> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> > ---
> > arch/x86/Kconfig | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > As somebody who works in "resource control", this prompt in oldconfig
> > certainly had me go wtf. Can we do something more specific?
>
> Well, since this is an interface to a hardware feature, we could call it
>
> Hardware Resource Control
>
> for example. I.e., HW_RESCTRL.
>
> Linus had another suggestion - CPU_RESCTRL - which sounds ok to me too.
>
> > Not insisting on this name, and I haven't renamed all the config
> > symbols yet, but we should probably fix this before 5.0 is released.
> >
> > Thanks!
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 26387c7bf305..426677b759c0 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -447,11 +447,11 @@ config RETPOLINE
> > support for full protection. The kernel may run slower.
> >
> > config X86_RESCTRL
> > - bool "Resource Control support"
> > + bool "x86 cache control support"
>
> Except that it is not only cache but memory (bandwidth) control too. So I guess
>
> bool "CPU Resource Control support"
This is still awefully close to the cgroup CPU resource
controller. Since it's more hardware-specific, and the config symbol
also has the x86 in it, how about "x86 CPU resource control support"?
---
From 2a24f6e30ed9dbc0abb96c73ec0e205e07034383 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <hannes@cmpxchg.org>
Date: Tue, 29 Jan 2019 17:44:36 -0500
Subject: [PATCH] x86: avoid confusion over the new RESCTRL config prompt
"Resource Control" is a very broad term for this CPU feature, and a
term that is also associated with containers, cgroups etc. This can
easily cause confusion.
Make the user prompt more specific.
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---
arch/x86/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 26387c7bf305..ac432379df11 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -447,11 +447,11 @@ config RETPOLINE
support for full protection. The kernel may run slower.
config X86_RESCTRL
- bool "Resource Control support"
+ bool "x86 CPU resource control support"
depends on X86 && (CPU_SUP_INTEL || CPU_SUP_AMD)
select KERNFS
help
- Enable Resource Control support.
+ Enable x86 CPU resource control support.
Provide support for the allocation and monitoring of system resources
usage by the CPU.
--
2.20.1
next prev parent reply other threads:[~2019-01-30 16:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 22:52 [PATCH] x86: avoid confusion over the new RESCTRL config prompt Johannes Weiner
2019-01-29 23:08 ` Borislav Petkov
2019-01-29 23:46 ` Luck, Tony
2019-01-30 16:46 ` Johannes Weiner [this message]
2019-01-30 17:19 ` Borislav Petkov
2019-01-30 19:56 ` Johannes Weiner
2019-02-01 19:18 ` Luck, Tony
2019-02-02 0:06 ` Borislav Petkov
2019-02-02 9:45 ` [tip:x86/urgent] x86/resctrl: Avoid confusion over the new X86_RESCTRL config tip-bot for Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130164626.GA17841@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=babu.moger@amd.com \
--cc=bp@suse.de \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).