From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C29BC169C4 for ; Fri, 1 Feb 2019 02:54:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1AE220863 for ; Fri, 1 Feb 2019 02:54:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548989664; bh=8RCVc/UR6RQLUvQQQztdVUBfDTbSQz/Ra9DMj49JNqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PPVAdo4RT3fSW4qU1zqb1q8+vumZuYYv0dp2Pk3WlYbQENvd2YEoQLRGO6YXkmWkY aosKpOWN/dNxr9k7LtL/IMEOnf4zQaepKHANvw8mNGcFiqpACrjXIu7YEnIbTtUgpJ RyBdtIlEmYfKHD+u/oxgF1/x8EAozhGHonKg/Fic= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728353AbfBACyV (ORCPT ); Thu, 31 Jan 2019 21:54:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:34346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbfBACyV (ORCPT ); Thu, 31 Jan 2019 21:54:21 -0500 Received: from dragon (61-216-91-114.HINET-IP.hinet.net [61.216.91.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6EB6720863; Fri, 1 Feb 2019 02:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548989659; bh=8RCVc/UR6RQLUvQQQztdVUBfDTbSQz/Ra9DMj49JNqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p7BWOEbn/9OIQs+CILDKvZ8zwagUsVRXIQWJ/Q06cwIG+Ggq95/AExJS/4GLxw5Th NEenY/+eKCv73QR11RpDeI3goTknhZo5yphL90+/05TgFjLoFN2tPkKeWfVRdduUaW PpdtofQUD6W53M35qG+VpOcyh3zlRG//VnAPhvac= Date: Fri, 1 Feb 2019 10:54:07 +0800 From: Shawn Guo To: Yogesh Narayan Gaur Cc: "linux-mtd@lists.infradead.org" , "bbrezillon@kernel.org" , "marek.vasut@gmail.com" , "broonie@kernel.org" , "linux-spi@vger.kernel.org" , "devicetree@vger.kernel.org" , "mark.rutland@arm.com" , "robh@kernel.org" , "linux-kernel@vger.kernel.org" , "frieder.schrempf@kontron.de" , "computersforpeace@gmail.com" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v8 3/5] arm64: dts: lx2160a: add FlexSPI node property Message-ID: <20190201025405.GA19882@dragon> References: <1547553487-9936-1-git-send-email-yogeshnarayan.gaur@nxp.com> <1547553487-9936-4-git-send-email-yogeshnarayan.gaur@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547553487-9936-4-git-send-email-yogeshnarayan.gaur@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 15, 2019 at 12:00:26PM +0000, Yogesh Narayan Gaur wrote: > Add fspi node property for LX2160A SoC for FlexSPI driver. > Property added for the FlexSPI controller and for the connected > slave device for the LX2160ARDB target. > This is having two SPI-NOR flash device, mt35xu512aba, connected > at CS0 and CS1. > > Signed-off-by: Yogesh Narayan Gaur > --- > Changes for v8: > - None > Changes for v7: > - None > Changes for v6: > - None > Changes for v5: > - None > Changes for v4: > - Incorporated Rob review comments. > Changes for v3: > - None. > Changes for v2: > - Incorporated Shawn review comments. > > .../boot/dts/freescale/fsl-lx2160a-rdb.dts | 22 +++++++++++++++++++ > .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 13 +++++++++++ > 2 files changed, 35 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > index 6481e5f20e69..70658946fbbe 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > @@ -50,6 +50,28 @@ > status = "okay"; > }; > > +&fspi { > + status = "okay"; > + > + mt35xu512aba0: flash@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "spansion,m25p80"; > + m25p,fast-read; > + spi-max-frequency = <50000000>; > + reg = <0>; > + }; > + > + mt35xu512aba1: flash@1 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "spansion,m25p80"; > + m25p,fast-read; > + spi-max-frequency = <50000000>; > + reg = <1>; > + }; > +}; > + > &i2c0 { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index a79f5c1ea56d..e3ff86201f73 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -762,5 +762,18 @@ > ; > dma-coherent; > }; > + > + fspi: spi@20c0000 { To keep the nodes sorted in unit-address, it should go after i2c@2070000. > + compatible = "nxp,lx2160a-fspi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x20c0000 0x0 0x10000>, > + <0x0 0x20000000 0x0 0x10000000>; I would align the indentation with the above. > + reg-names = "fspi_base", "fspi_mmap"; > + interrupts = <0 25 0x4>; /* Level high type */ interrupts = ; so that we can save the comment there. I fixed up all these small things and applied the patch. Shawn > + clocks = <&clockgen 4 3>, <&clockgen 4 3>; > + clock-names = "fspi_en", "fspi"; > + status = "disabled"; > + }; > }; > }; > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel