From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Tony Krowiak <akrowiak@linux.ibm.com>
Cc: Sebastian Ott <sebott@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
oberpar@linux.ibm.com, freude@linux.ibm.com,
pmorel@linux.ibm.com, pasic@linux.ibm.com, cohuck@redhat.com
Subject: Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command
Date: Fri, 1 Feb 2019 10:01:59 +0100 [thread overview]
Message-ID: <20190201090159.GC3770@osiris> (raw)
In-Reply-To: <88b72363-9dca-4653-c326-9c37b6349a32@linux.ibm.com>
On Thu, Jan 31, 2019 at 06:28:39PM -0500, Tony Krowiak wrote:
> On 1/30/19 1:32 PM, Sebastian Ott wrote:
> >On Wed, 30 Jan 2019, Tony Krowiak wrote:
> >>+#if IS_ENABLED(CONFIG_ZCRYPT)
> >>+void ap_bus_cfg_chg(void);
> >>+#else
> >>+#error "no CONFIG_ZCRYPT"
> > ^
> >I don't think that's the right thing to do here.
>
> I'd like to leave it. If somebody edits .config
> and sets CONFIG_ZCRYPT=n, then the build will
> fail. The preprocessor error above tells them
> why.
No, the kernel build should never fail if a config option is not set.
Also the above should be "#ifdef CONFIG_ZCRYPT".
In addition (this isn't quoted unfortunately) the alternative function
in the header file is missing the "inline" attribute. Can you please
add that too?
static inline void ap_bus_cfg_chg(void) { }
> >>+* A config change has happened, Force an ap bus rescan.
> >>+*/
> >>+void ap_bus_cfg_chg(void)
> >>+{
> >>+ AP_DBF(DBF_INFO, "%s config change, forcing bus rescan\n", __func__);
> >>+
> >>+ ap_bus_force_rescan();
> >>+}
> >>+EXPORT_SYMBOL(ap_bus_cfg_chg);
> >
> >There is no need for the export symbol - you don't call that function
> >from module code.
> >As an unrelated question, just to be sure: ap_bus.c is compiled as
> >built-in even with ZCRYPT=m, right?
>
> No. If you edit .config and set CONFIG_ZCRYPT=m, ap_bus.c will be built
> into the zcrypt.ko module. Through some other magic, the zcrypt module
> is loaded when linux boots.
If that happens, then we have a build problem that needs to be
fixed. What exactly are you doing to get the ap code linked into the
zcrypt module?
next prev parent reply other threads:[~2019-02-01 9:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 17:48 [PATCH] zcrypt: handle AP Info notification from CHSC SEI command Tony Krowiak
2019-01-30 18:32 ` Sebastian Ott
2019-01-31 23:28 ` Tony Krowiak
2019-02-01 9:01 ` Heiko Carstens [this message]
2019-02-01 11:08 ` Martin Schwidefsky
2019-02-01 13:05 ` Heiko Carstens
2019-02-01 15:40 ` Tony Krowiak
2019-02-01 15:38 ` Tony Krowiak
2019-02-04 10:06 ` Harald Freudenberger
2019-02-05 20:26 ` Tony Krowiak
2019-02-04 10:01 ` Sebastian Ott
2019-02-05 20:27 ` Tony Krowiak
2019-02-21 10:42 ` Harald Freudenberger
2019-02-21 12:12 ` Cornelia Huck
2019-02-21 12:55 ` Heiko Carstens
2019-01-31 9:09 ` Pierre Morel
2019-01-31 23:32 ` Tony Krowiak
2019-01-31 9:23 ` Pierre Morel
2019-01-31 9:55 ` Cornelia Huck
2019-01-31 23:50 ` Tony Krowiak
2019-02-01 14:35 ` Cornelia Huck
2019-02-01 15:50 ` Tony Krowiak
2019-02-04 10:15 ` Harald Freudenberger
2019-02-04 12:07 ` Cornelia Huck
2019-02-05 20:30 ` Tony Krowiak
2019-02-03 9:25 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201090159.GC3770@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=freude@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).