From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0DB9C282D8 for ; Fri, 1 Feb 2019 12:30:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68E49218F0 for ; Fri, 1 Feb 2019 12:30:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="eXBQwULU"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="l6A1JyRp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729034AbfBAMaL (ORCPT ); Fri, 1 Feb 2019 07:30:11 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:40486 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725807AbfBAMaL (ORCPT ); Fri, 1 Feb 2019 07:30:11 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 43EE1608C5; Fri, 1 Feb 2019 12:30:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549024210; bh=HTbqmqRR27PzJawrp5SB3MWdfo3LZvDyZk/Ek8U0AYE=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=eXBQwULU957p9YC0Jsw1n1iwsLGKaKvxfRQznZp6miY72GcDoBkaLX8UjCFyaxnlz vXnACTY2EivwV+Nj8/Uqmmcl2Bq6UWtwxJSYZ23+5jSFp/uSrm/3KwYw2rHUuD+7gp 1OndvitPbdvKYX0ah6XJAhh8dlVmA9G3MLy9t3vo= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7ECF36043F; Fri, 1 Feb 2019 12:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549024209; bh=HTbqmqRR27PzJawrp5SB3MWdfo3LZvDyZk/Ek8U0AYE=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=l6A1JyRp1HvCx/66AQ6hqY0+ob5YtsfS+0icd8kQjWXMZCPudco/lfrK6572h1E4X /xe7qLoBjcX56F5rgBs9TeDAwX7xjz1hpoOdR4Zqqat83X8L0mN6hLInKJNINd9jh6 REwD5qKs+a9PW3jQ0QfW5tkelR29L632aOmakFCw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7ECF36043F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wlcore: no need to check return value of debugfs_create functions From: Kalle Valo In-Reply-To: <20190122152151.16139-25-gregkh@linuxfoundation.org> References: <20190122152151.16139-25-gregkh@linuxfoundation.org> To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Tony Lindgren , linux-wireless@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190201123010.43EE1608C5@smtp.codeaurora.org> Date: Fri, 1 Feb 2019 12:30:10 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Kalle Valo > Cc: Tony Lindgren > Cc: linux-wireless@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > Acked-by: Tony Lindgren Patch applied to wireless-drivers-next.git, thanks. ad2106ca00df wlcore: no need to check return value of debugfs_create functions -- https://patchwork.kernel.org/patch/10775793/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches