From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9FC1C282D8 for ; Fri, 1 Feb 2019 16:50:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9199E21726 for ; Fri, 1 Feb 2019 16:50:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729214AbfBAQuc (ORCPT ); Fri, 1 Feb 2019 11:50:32 -0500 Received: from 8bytes.org ([81.169.241.247]:36774 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726172AbfBAQub (ORCPT ); Fri, 1 Feb 2019 11:50:31 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id E3191273; Fri, 1 Feb 2019 17:50:29 +0100 (CET) Date: Fri, 1 Feb 2019 17:50:29 +0100 From: Joerg Roedel To: Christoph Hellwig Cc: Konrad Rzeszutek Wilk , Marek Szyprowski , Robin Murphy , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Joerg Roedel , Mike Rapoport Subject: Re: [PATCH] swiotlb: Return error from swiotlb_init_with_tbl() Message-ID: <20190201165029.GU32526@8bytes.org> References: <20190131162424.10477-1-joro@8bytes.org> <20190201081208.GB15512@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190201081208.GB15512@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 01, 2019 at 09:12:08AM +0100, Christoph Hellwig wrote: > On Thu, Jan 31, 2019 at 05:24:24PM +0100, Joerg Roedel wrote: > > - io_tlb_list = memblock_alloc( > > + io_tlb_list = memblock_alloc_nopanic( > > PAGE_ALIGN(io_tlb_nslabs * sizeof(int)), > > PAGE_SIZE); > > Mike just killed the _nopanic versions and made the normal ones not > panic. This sounds like a change to break quite a couple of places in the kernel. But okay, it just makes this hunk obsolete. Joerg