From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Trent Piepho <tpiepho@impinj.com>,
Lucas Stach <l.stach@pengutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Chris Healy <cphealy@gmail.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
"A.s. Dong" <aisheng.dong@nxp.com>,
Richard Zhu <hongxing.zhu@nxp.com>,
linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v6 2/4] PCI: imx6: Mark PHY functions as i.MX6 specific
Date: Fri, 1 Feb 2019 16:59:50 +0000 [thread overview]
Message-ID: <20190201165950.GA22887@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <20190124201522.8973-3-andrew.smirnov@gmail.com>
On Thu, Jan 24, 2019 at 12:15:20PM -0800, Andrey Smirnov wrote:
> PCIE PHY IP block on i.MX7D differs from the one used on i.MX6 family,
> so none of the code in current implementation of imx6_setup_phy_mpll()
> is applicable.
So :) ? Add a conclusive statement to the commit log.
Lorenzo
> Tested-by: Trent Piepho <tpiepho@impinj.com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Leonard Crestez <leonard.crestez@nxp.com>
> Cc: "A.s. Dong" <aisheng.dong@nxp.com>
> Cc: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: linux-imx@nxp.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index efff3d5e9162..c55d93c1187d 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -41,8 +41,11 @@ enum imx6_pcie_variants {
> IMX7D,
> };
>
> +#define IMX6_PCIE_FLAG_IMX6_PHY BIT(0)
> +
> struct imx6_pcie_drvdata {
> enum imx6_pcie_variants variant;
> + u32 flags;
> };
>
> struct imx6_pcie {
> @@ -256,6 +259,9 @@ static void imx6_pcie_reset_phy(struct imx6_pcie *imx6_pcie)
> {
> u32 tmp;
>
> + if (!(imx6_pcie->drvdata->flags & IMX6_PCIE_FLAG_IMX6_PHY))
> + return;
> +
> pcie_phy_read(imx6_pcie, PHY_RX_OVRD_IN_LO, &tmp);
> tmp |= (PHY_RX_OVRD_IN_LO_RX_DATA_EN |
> PHY_RX_OVRD_IN_LO_RX_PLL_EN);
> @@ -573,6 +579,9 @@ static int imx6_setup_phy_mpll(struct imx6_pcie *imx6_pcie)
> int mult, div;
> u32 val;
>
> + if (!(imx6_pcie->drvdata->flags & IMX6_PCIE_FLAG_IMX6_PHY))
> + return 0;
> +
> switch (phy_rate) {
> case 125000000:
> /*
> @@ -1088,12 +1097,15 @@ static void imx6_pcie_shutdown(struct platform_device *pdev)
> static const struct imx6_pcie_drvdata drvdata[] = {
> [IMX6Q] = {
> .variant = IMX6Q,
> + .flags = IMX6_PCIE_FLAG_IMX6_PHY,
> },
> [IMX6SX] = {
> .variant = IMX6SX,
> + .flags = IMX6_PCIE_FLAG_IMX6_PHY,
> },
> [IMX6QP] = {
> .variant = IMX6QP,
> + .flags = IMX6_PCIE_FLAG_IMX6_PHY,
> },
> [IMX7D] = {
> .variant = IMX7D,
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-02-01 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 20:15 [PATCH v6 0/4] PCIE support for i.MX8MQ Andrey Smirnov
2019-01-24 20:15 ` [PATCH v6 1/4] PCI: imx6: Introduce drvdata Andrey Smirnov
2019-01-24 20:15 ` [PATCH v6 2/4] PCI: imx6: Mark PHY functions as i.MX6 specific Andrey Smirnov
2019-02-01 16:59 ` Lorenzo Pieralisi [this message]
2019-01-24 20:15 ` [PATCH v6 3/4] PCI: imx6: Convert DIRECT_SPEED_CHANGE quirk code to use a flag Andrey Smirnov
2019-01-24 20:15 ` [PATCH v6 4/4] PCI: imx6: Add support for i.MX8MQ Andrey Smirnov
2019-02-01 17:01 ` [PATCH v6 0/4] PCIE " Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201165950.GA22887@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=aisheng.dong@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=bhelgaas@google.com \
--cc=cphealy@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=hongxing.zhu@nxp.com \
--cc=l.stach@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).