From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, Matteo Croce <mcroce@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Laura Abbott <labbott@redhat.com>,
YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH] bpfilter: remove extra header search paths for bpfilter_umh
Date: Fri, 1 Feb 2019 15:59:24 -0800 [thread overview]
Message-ID: <20190201235852.l7tlw5jkcpkwivsd@ast-mbp> (raw)
In-Reply-To: <1548904535-9853-1-git-send-email-yamada.masahiro@socionext.com>
On Thu, Jan 31, 2019 at 12:15:35PM +0900, Masahiro Yamada wrote:
> Currently, the header search paths -Itools/include and
> -Itools/include/uapi are not used. Let's drop the unused code.
>
> We can remove -I. too by fixing up one C file.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Perhaps, are these extra header search paths for
> more upstreaming in the future?
>
> If this patch is rejected, I will send an alternative one.
>
> To clean up the Kbuild core,
> I want to drop as many unused header search paths as possible.
>
>
> net/bpfilter/Makefile | 1 -
> net/bpfilter/main.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile
> index 0947ee7..5d6c776 100644
> --- a/net/bpfilter/Makefile
> +++ b/net/bpfilter/Makefile
> @@ -5,7 +5,6 @@
>
> hostprogs-y := bpfilter_umh
> bpfilter_umh-objs := main.o
> -KBUILD_HOSTCFLAGS += -I. -Itools/include/ -Itools/include/uapi
> HOSTCC := $(CC)
>
> ifeq ($(CONFIG_BPFILTER_UMH), y)
> diff --git a/net/bpfilter/main.c b/net/bpfilter/main.c
> index 1317f10..61ce845 100644
> --- a/net/bpfilter/main.c
> +++ b/net/bpfilter/main.c
> @@ -6,7 +6,7 @@
> #include <sys/socket.h>
> #include <fcntl.h>
> #include <unistd.h>
> -#include "include/uapi/linux/bpf.h"
> +#include "../../include/uapi/linux/bpf.h"
argh. that's not pretty.
I would prefer to keep -I in a makefile
next prev parent reply other threads:[~2019-02-01 23:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 3:15 [PATCH] bpfilter: remove extra header search paths for bpfilter_umh Masahiro Yamada
2019-02-01 23:59 ` Alexei Starovoitov [this message]
2019-02-02 13:40 ` Masahiro Yamada
2019-02-04 4:13 ` David Miller
2019-02-21 14:42 Guenter Roeck
2019-02-21 15:54 ` Masahiro Yamada
2019-02-21 18:05 ` Guenter Roeck
2019-02-21 19:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201235852.l7tlw5jkcpkwivsd@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).