linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yifeng Li <tomli@tomli.me>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: Yifeng Li <tomli@tomli.me>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Teddy Wang <teddy.wang@siliconmotion.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH 0/8] fbdev: sm712fb: implement 2D acceleration w/ cleanups.
Date: Sat,  2 Feb 2019 14:16:40 +0800	[thread overview]
Message-ID: <20190202061648.30374-1-tomli@tomli.me> (raw)

Previously, in staging/sm7xxfb (now fbdev/sm712fb), 2D acceleration
was implemented, but after its submission, a critical bug that causes
total system hang was discovered, as a stopgap measure, 2D ops was
completele removed in commit 3af805735a25 ("staging: sm7xx: remove the
buggy 2D acceleration support") and never implemented again.

It created a massive usability problem - on YeeLoong 8089, a notable
MIPS platform which uses SM712 - even scrolling a single line of text
on the console required an unaccelerated screen redraw, running "dmesg"
typically takes 8-11 seconds, and absurdly, printf(), became a significant
performance bottleneck that slows down GCC and "make", make the computer
largely unusable.

So I decided to take a look. Most of the my actual development was done
in 2014 in a personal out-of-tree driver, I did not mainline it because
2D acceleration was not working properly in 24-bit color. I discovered
the solution in early 2019 and now it's ready to be mainlined.

This commit reimplements the 2D acceleration for sm712fb. Unlike the
original implementation, which was messy and unnecessarily complicated
by calling a 2D acceleration wrapper file with many unneeded functions,
this is a minimum and (relatively) clean implementation. My tests have
shown that running "dmesg" only takes 0.9 seconds, a performance boost
of 950%. System hangs did not occur in my tests.

Currently, 2D acceleration is only supported on SM712 with little-endian
CPUs, it's disabled on Big Endian systems and SM720 chips as a safety
measure, since I code for myself without any monetary or hardware support
from any company or OEMs, I don't have the hardware and it's completely
untested. I should be also to purchase a Big Endian test platform and add
proper support soon.  If you have a Big-Endian platform with SM7xx
available for testing, please send an E-mail to me immediately! Thanks!

Also, thanks to Miodrag Vallat and other OpenBSD developers, this work
would be impossible without their code, that served as a reference
implementation for me.

Finally, during the development and testing of 2D acceleration, the
modesetting code of this driver received a minor cleanup, and many
issues about issues about the modesetting code and this driver in
general have been documented.

Yifeng Li (8):
  fbdev: sm712fb: update copyright headers.
  fbdev: sm712fb: use type "u8" for 8-bit I/O.
  fbdev: sm712fb: add 2D-related I/O headers and functions.
  fbdev: sm712fb: support 2D acceleration on SM712 w/ Little-Endian CPU.
  fbdev: sm712fb: add 32-bit color modes, drops some other modes.
  Documentation: fb: sm712fb: add information mainly about 2D.
  fbdev: sm712fb: Kconfig: add information about docs.
  MAINTAINERS: sm712fb: list myself as one maintainer.

 Documentation/fb/sm712fb.txt  | 123 +++++++-
 MAINTAINERS                   |   1 +
 drivers/video/fbdev/Kconfig   |   4 +
 drivers/video/fbdev/sm712.h   | 129 +++++++-
 drivers/video/fbdev/sm712fb.c | 574 ++++++++++++++++++++++++++--------
 5 files changed, 679 insertions(+), 152 deletions(-)

-- 
2.20.1


             reply	other threads:[~2019-02-02  6:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-02  6:16 Yifeng Li [this message]
2019-02-02  6:16 ` [PATCH 1/8] fbdev: sm712fb: update copyright headers Yifeng Li
2019-02-02  6:16 ` [PATCH 2/8] fbdev: sm712fb: use type "u8" for 8-bit I/O Yifeng Li
2019-02-02  6:16 ` [PATCH 3/8] fbdev: sm712fb: add 2D-related I/O headers and functions Yifeng Li
2019-02-02  6:16 ` [PATCH 4/8] fbdev: sm712fb: support 2D acceleration on SM712 w/ Little-Endian CPU Yifeng Li
2019-02-02  6:16 ` [PATCH 5/8] fbdev: sm712fb: add 32-bit color modes, drops some other modes Yifeng Li
2019-02-02  6:16 ` [PATCH 6/8] Documentation: fb: sm712fb: add information mainly about 2D Yifeng Li
2019-02-02  6:16 ` [PATCH 7/8] fbdev: sm712fb: Kconfig: add information about docs Yifeng Li
2019-02-02  6:16 ` [PATCH 8/8] MAINTAINERS: sm712fb: list myself as one maintainer Yifeng Li
2019-02-04  9:26 ` [PATCH 0/8] fbdev: sm712fb: implement 2D acceleration w/ cleanups Daniel Vetter
2019-02-04 22:06   ` Tom Li
2019-02-05  9:02     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190202061648.30374-1-tomli@tomli.me \
    --to=tomli@tomli.me \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).