From: Viresh Kumar <viresh.kumar@linaro.org>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: ilia.lin@gmail.com, rjw@rjwysocki.net, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: qcom-kryo: make some variables static
Date: Mon, 4 Feb 2019 12:01:00 +0530 [thread overview]
Message-ID: <20190204063100.v3ebrh52hm5kxxtw@vireshk-i7> (raw)
In-Reply-To: <20190204061310.1211-1-tiny.windzz@gmail.com>
On 04-02-19, 01:13, Yangtao Li wrote:
> The variables are local to the source and do not
> need to be in global scope, so make them static.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpufreq/qcom-cpufreq-kryo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
> index 2a3675c24032..1c8583cc06a2 100644
> --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> @@ -42,7 +42,7 @@ enum _msm8996_version {
> NUM_OF_MSM8996_VERSIONS,
> };
>
> -struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
> +static struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
>
> static enum _msm8996_version qcom_cpufreq_kryo_get_msm_id(void)
> {
Applied. Thanks.
--
viresh
prev parent reply other threads:[~2019-02-04 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 6:13 [PATCH] cpufreq: qcom-kryo: make some variables static Yangtao Li
2019-02-04 6:31 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204063100.v3ebrh52hm5kxxtw@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=ilia.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).