From: Vinod Koul <vkoul@kernel.org>
To: Leonid Iziumtsev <leonid.iziumtsev@gmail.com>
Cc: dmaengine@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de
Subject: Re: [PATCH] dmaengine: imx-dma: fix wrong callback invoke
Date: Mon, 4 Feb 2019 12:36:03 +0530 [thread overview]
Message-ID: <20190204070603.GH4296@vkoul-mobl> (raw)
In-Reply-To: <20190115171523.702-1-leonid.iziumtsev@gmail.com>
On 15-01-19, 17:15, Leonid Iziumtsev wrote:
> Once the "ld_queue" list is not empty, next descriptor will migrate
> into "ld_active" list. The "desc" variable will be overwritten
> during that transition. And later the dmaengine_desc_get_callback_invoke()
> will use it as an argument. As result we invoke wrong callback.
>
> That behaviour was in place since:
> commit fcaaba6c7136 ("dmaengine: imx-dma: fix callback path in tasklet").
> But after commit 4cd13c21b207 ("softirq: Let ksoftirqd do its job")
> things got worse, since possible delay between tasklet_schedule()
> from DMA irq handler and actual tasklet function execution got bigger.
> And that gave more time for new DMA request to be submitted and
> to be put into "ld_queue" list.
>
> It has been noticed that DMA issue is causing problems for "mxc-mmc"
> driver. While stressing the system with heavy network traffic and
> writing/reading to/from sd card simultaneously the timeout may happen:
>
> 10013000.sdhci: mxcmci_watchdog: read time out (status = 0x30004900)
>
> That often lead to file system corruption.
Applied and tagged to stable, thanks
--
~Vinod
prev parent reply other threads:[~2019-02-04 7:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 17:15 [PATCH] dmaengine: imx-dma: fix wrong callback invoke Leonid Iziumtsev
2019-01-20 10:52 ` Vinod Koul
2019-01-23 11:43 ` Fabio Estevam
2019-02-04 7:06 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204070603.GH4296@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=leonid.iziumtsev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).