From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCEF7C282C4 for ; Mon, 4 Feb 2019 10:44:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BC6E2075B for ; Mon, 4 Feb 2019 10:44:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549277074; bh=hFoPCJbhDExNxAeUXBtS+ejoC1Ml2xn5nLgttlU8ldk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=d5+VMOvOig1LF/5FOGF/agTuz5gpVro+NAOTSEo6LNn1Q56U9DiRzNfvIY9UeuXy+ ekyBAd0CkljMdO2u4UqHNUfHKxQcvZ0qXLj0rl/MKS3P0U2xN9FdFuOoa6dDIqJRLr v99vDl4U9Z/oyCEiR1RRgR1tpY/7+4idOpvYtugQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731016AbfBDKoc (ORCPT ); Mon, 4 Feb 2019 05:44:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:42326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730982AbfBDKob (ORCPT ); Mon, 4 Feb 2019 05:44:31 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D92552176F; Mon, 4 Feb 2019 10:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549277070; bh=hFoPCJbhDExNxAeUXBtS+ejoC1Ml2xn5nLgttlU8ldk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QCTYUMMJvgBPIj+S01lhk68LNvt50xHrkw98YmyeAokVJdOfRWw7VKfGu0AOyR30w A9/9XQa7K+mVbacdrTqWl+86ea2bsvGiGP0QqGfiHzwzN74fe+SKLOwjjWMPmg9W5z U7dF5huGBR7MmIaM6vPCk50oj4aU7138sCh1ie7U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Toshiaki Makita , Jason Wang , "Michael S. Tsirkin" , "David S. Miller" Subject: [PATCH 4.14 12/46] virtio_net: Dont enable NAPI when interface is down Date: Mon, 4 Feb 2019 11:36:43 +0100 Message-Id: <20190204103610.753340029@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190204103608.651205056@linuxfoundation.org> References: <20190204103608.651205056@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Toshiaki Makita [ Upstream commit 8be4d9a492f88b96d4d3a06c6cbedbc40ca14c83 ] Commit 4e09ff536284 ("virtio-net: disable NAPI only when enabled during XDP set") tried to fix inappropriate NAPI enabling/disabling when !netif_running(), but was not complete. On error path virtio_net could enable NAPI even when !netif_running(). This can cause enabling NAPI twice on virtnet_open(), which would trigger BUG_ON() in napi_enable(). Fixes: 4941d472bf95b ("virtio-net: do not reset during XDP set") Signed-off-by: Toshiaki Makita Acked-by: Jason Wang Acked-by: Michael S. Tsirkin Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/virtio_net.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2034,8 +2034,10 @@ static int virtnet_xdp_set(struct net_de return 0; err: - for (i = 0; i < vi->max_queue_pairs; i++) - virtnet_napi_enable(vi->rq[i].vq, &vi->rq[i].napi); + if (netif_running(dev)) { + for (i = 0; i < vi->max_queue_pairs; i++) + virtnet_napi_enable(vi->rq[i].vq, &vi->rq[i].napi); + } if (prog) bpf_prog_sub(prog, vi->max_queue_pairs - 1); return err;