From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA1FC282C4 for ; Mon, 4 Feb 2019 10:53:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B10E9217FA for ; Mon, 4 Feb 2019 10:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549277624; bh=pqZSE9YREV4s1XzfM9woSywf2+AJNLWmXm50JmtCzGY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lIcIpReXVXwHPJl8vNbhulBiJr3sMWjcMIATGJhuv9MpzessVSgKx3aw7eVoJC6sj wOaDXMvCHXLxBCkj3XOk77KIc+e4049A0uhOtirUtbz5GEFjiQTXyu3ugh25myUy5e aHOfITI+VWcIckXLlw25bzETLBGUljYGw0tTPoJw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732457AbfBDKxn (ORCPT ); Mon, 4 Feb 2019 05:53:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:51312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731763AbfBDKxl (ORCPT ); Mon, 4 Feb 2019 05:53:41 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36DE3217D6; Mon, 4 Feb 2019 10:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549277620; bh=pqZSE9YREV4s1XzfM9woSywf2+AJNLWmXm50JmtCzGY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rpNF48bV6tEz0SDp8GwRzGfo0hVXArxsDSxDgtYHgGn5NFXRf8LoZqT5xlSEMGNae YQ9gHzb/8VdkIsrs/7FCtDowPcC60c8wSaf9n3Hs8exvMVGufmx/W8UC9gdEln+FLW l1+IXECDHEX2W73D9KNcCf17NnFVDULlBM123DVs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Neo Hou , Baolin Wang , Bartosz Golaszewski Subject: [PATCH 4.20 53/80] gpio: sprd: Fix incorrect irq type setting for the async EIC Date: Mon, 4 Feb 2019 11:37:13 +0100 Message-Id: <20190204103627.645456306@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190204103620.287366543@linuxfoundation.org> References: <20190204103620.287366543@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Neo Hou commit f785ffb61605734b518afa766d1b5445e9f38c8d upstream. When setting async EIC as IRQ_TYPE_EDGE_BOTH type, we missed to set the SPRD_EIC_ASYNC_INTMODE register to 0, which means detecting edge signals. Thus this patch fixes the issue. Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support") Cc: Signed-off-by: Neo Hou Signed-off-by: Baolin Wang Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-eic-sprd.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpio/gpio-eic-sprd.c +++ b/drivers/gpio/gpio-eic-sprd.c @@ -379,6 +379,7 @@ static int sprd_eic_irq_set_type(struct irq_set_handler_locked(data, handle_edge_irq); break; case IRQ_TYPE_EDGE_BOTH: + sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0); sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 1); irq_set_handler_locked(data, handle_edge_irq); break;