From: Peter Zijlstra <peterz@infradead.org>
To: Juri Lelli <juri.lelli@redhat.com>
Cc: longman@redhat.com, mingo@redhat.com, rostedt@goodmis.org,
linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it,
claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it,
bristot@redhat.com, mathieu.poirier@linaro.org,
lizefan@huawei.com, cgroups@vger.kernel.org, tj@kernel.org
Subject: Re: [PATCH v6 0/5] sched/deadline: fix cpusets bandwidth accounting
Date: Mon, 4 Feb 2019 13:18:25 +0100 [thread overview]
Message-ID: <20190204121825.GE17550@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190204090211.GA10449@localhost.localdomain>
On Mon, Feb 04, 2019 at 10:02:11AM +0100, Juri Lelli wrote:
> On 18/01/19 17:46, Juri Lelli wrote:
> > On 18/01/19 08:17, Tejun Heo wrote:
> > > On Thu, Jan 17, 2019 at 09:47:34AM +0100, Juri Lelli wrote:
> > > > Hi,
> > > >
> > > > v6 of a series of patches, originally authored by Mathieu, with the intent
> > > > of fixing a long standing issue of SCHED_DEADLINE bandwidth accounting.
> > > > As originally reported by Steve [1], when hotplug and/or (certain)
> > > > cpuset reconfiguration operations take place, DEADLINE bandwidth
> > > > accounting information is lost since root domains are destroyed and
> > > > recreated.
> > > >
> > > > Mathieu's approach is based on restoring bandwidth accounting info on
> > > > the newly created root domains by iterating through the (DEADLINE) tasks
> > > > belonging to the configured cpuset(s).
> > > >
> > > > Apart from some minor refactoring needed to rebase the set on top of
> > > > Waiman Long's cpuset for cgroup series (now mainline), two changes worth
> > > > of notice:
> > >
> > > Generally looks good to me but can you please ask Waiman to take a
> > > look?
> >
> > Argh! I should have cc-ed him in the first instance.
> >
> > Thanks for reviewing.
> >
> > Waiman, do you see anything wrong with this series? Thanks!
> >
> > https://lore.kernel.org/lkml/20190117084739.17078-1-juri.lelli@redhat.com/
>
> Ping?
Basically looks OK to me; wlthough I think I prefer the callback_lock /
rq->lock ordering to be the other way around.
Waiman, you OK with this one?
next prev parent reply other threads:[~2019-02-04 12:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 8:47 [PATCH v6 0/5] sched/deadline: fix cpusets bandwidth accounting Juri Lelli
2019-01-17 8:47 ` [PATCH v6 1/5] sched/topology: Adding function partition_sched_domains_locked() Juri Lelli
2019-01-17 8:47 ` [PATCH v6 2/5] sched/core: Streamlining calls to task_rq_unlock() Juri Lelli
2019-01-17 8:47 ` [PATCH v6 3/5] cgroup/cpuset: make callback_lock raw Juri Lelli
2019-02-04 11:55 ` Peter Zijlstra
2019-02-05 9:18 ` Juri Lelli
2019-02-04 12:02 ` Peter Zijlstra
2019-02-04 12:07 ` Peter Zijlstra
2019-02-05 9:18 ` Juri Lelli
2019-01-17 8:47 ` [PATCH v6 4/5] sched/core: Prevent race condition between cpuset and __sched_setscheduler() Juri Lelli
2019-02-04 12:10 ` Peter Zijlstra
2019-02-05 9:51 ` Juri Lelli
2019-02-05 11:20 ` Peter Zijlstra
2019-02-05 11:49 ` Juri Lelli
2019-01-17 8:47 ` [PATCH v6 5/5] cpuset: Rebuild root domain deadline accounting information Juri Lelli
2019-01-18 16:17 ` [PATCH v6 0/5] sched/deadline: fix cpusets bandwidth accounting Tejun Heo
2019-01-18 16:46 ` Juri Lelli
2019-02-04 9:02 ` Juri Lelli
2019-02-04 12:18 ` Peter Zijlstra [this message]
2019-02-04 18:45 ` Waiman Long
2019-02-05 9:18 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204121825.GE17550@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=claudio@evidence.eu.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=longman@redhat.com \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@santannapisa.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).