From: Anders Roxell <anders.roxell@linaro.org> To: ard.biesheuvel@linaro.org Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Anders Roxell <anders.roxell@linaro.org> Subject: [PATCH] firmware: efi: arm-runtime: fix build error void value not ignored Date: Mon, 4 Feb 2019 14:29:04 +0100 Message-ID: <20190204132904.9288-1-anders.roxell@linaro.org> (raw) Commit e2a2e56e4082 ("arm64: dump: no need to check return value of debugfs_create functions") changed the return value from 'int' to 'void'. ../drivers/firmware/efi/arm-runtime.c: In function ‘ptdump_init’: ../drivers/firmware/efi/arm-runtime.c:52:9: error: void value not ignored as it ought to be return ptdump_debugfs_register(&efi_ptdump_info, "efi_page_tables"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/firmware/efi/arm-runtime.c:53:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ Rework so that function 'ptdump_init' doesn't 'return ptdump_debug_fs_register(...' since the function can work or not, but the code logic should never do something different based on this. Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- drivers/firmware/efi/arm-runtime.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c index 352bd2473162..b9ae798192d6 100644 --- a/drivers/firmware/efi/arm-runtime.c +++ b/drivers/firmware/efi/arm-runtime.c @@ -49,7 +49,8 @@ static int __init ptdump_init(void) if (!efi_enabled(EFI_RUNTIME_SERVICES)) return 0; - return ptdump_debugfs_register(&efi_ptdump_info, "efi_page_tables"); + ptdump_debugfs_register(&efi_ptdump_info, "efi_page_tables"); + return 0; } device_initcall(ptdump_init); -- 2.20.1
next reply index Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-04 13:29 Anders Roxell [this message] 2019-02-04 13:42 ` Ard Biesheuvel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190204132904.9288-1-anders.roxell@linaro.org \ --to=anders.roxell@linaro.org \ --cc=ard.biesheuvel@linaro.org \ --cc=linux-efi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git