From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5CBDC282C4 for ; Mon, 4 Feb 2019 14:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7D912082F for ; Mon, 4 Feb 2019 14:42:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Yi49uZ5E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730831AbfBDOm5 (ORCPT ); Mon, 4 Feb 2019 09:42:57 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:43814 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729226AbfBDOmz (ORCPT ); Mon, 4 Feb 2019 09:42:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pTnXHK2vKRTKZw4ElPdYOYDLY44/zEdrheMpJ/YQ9II=; b=Yi49uZ5EI4KHnYwyIxJAaVKgF kdusWQMsGvDZVfg4RMFKOIXisCwJ7otrB7v4yKO1zELzEPeDFiNqKuXauq5TXsHKjF1C7RR8Jx03Q 0gu6nCZIbgrctS6P3R/ZhhpM/XqlaAE3lcL+m8ovoFf23iLzHexQAMzS17bE8d4Y5oHY+Chfc9SuK g4G0UnuzsgEG1/xo0MKeNa29kkYCN2FfPmP5CniDAu051GdjiBoXjV6r7sn6sCFfHe2gE58VlvrkX tQUqWCtxLyi7z4Ybi9SDqXzILuqT2pJw4ULEpzJMmX0AvjMmJx35DiP9yI0FYtCypQaJP53FoykZg 2o0JRlfCg==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gqfSO-0008D3-3b; Mon, 04 Feb 2019 14:42:44 +0000 Date: Mon, 4 Feb 2019 06:42:43 -0800 From: Christoph Hellwig To: David Kozub Cc: Jens Axboe , Jonathan Derrick , Scott Bauer , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Subject: Re: [PATCH v4 01/16] block: sed-opal: fix typos and formatting Message-ID: <20190204144243.GA31132@infradead.org> References: <1549054223-12220-1-git-send-email-zub@linux.fjfi.cvut.cz> <1549054223-12220-2-git-send-email-zub@linux.fjfi.cvut.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1549054223-12220-2-git-send-email-zub@linux.fjfi.cvut.cz> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 01, 2019 at 09:50:08PM +0100, David Kozub wrote: > This should make no change in functionality. > The formatting changes were triggered by checkpatch.pl. > > Signed-off-by: David Kozub > Reviewed-by: Scott Bauer > --- > block/sed-opal.c | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/block/sed-opal.c b/block/sed-opal.c > index e0de4dd448b3..c882a193e162 100644 > --- a/block/sed-opal.c > +++ b/block/sed-opal.c > @@ -11,8 +11,8 @@ > * > * This program is distributed in the hope it will be useful, but WITHOUT > * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > - * more details. > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > + * for more details. What exactly is the fix here? If we want to fix the licence boilerplate we should switch it to an SPDX tag instead. Otherwise this looks fine to me.