From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Nick Clifton <nickc@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH] perf tools: Filter out hidden symbols from labels
Date: Mon, 4 Feb 2019 11:45:47 -0300 [thread overview]
Message-ID: <20190204144547.GG5593@kernel.org> (raw)
In-Reply-To: <20190128133526.GD15461@krava>
Em Mon, Jan 28, 2019 at 02:35:26PM +0100, Jiri Olsa escreveu:
> On Tue, Jan 15, 2019 at 06:38:38PM +0100, Jiri Olsa wrote:
> > On Tue, Jan 15, 2019 at 04:13:16PM +0000, Nick Clifton wrote:
> > > > When perf is built with annobin plugin (RHEL8 build) extra symbols
> > > > are added to its binary:
<SNIP>
> > > > + elf_sym__visibility(sym) != STV_HIDDEN;
> > >
> > > Just to be awkward, if you are going to ignore STV_HIDDEN
> > > symbols then you should probably also ignore STV_INTERNAL ones
> > > as well... Annobin does not generate them, but you never know,
> > > one day some other tool might create some.
> >
> > sounds good, thanks
>
> there were no objections for rfc, sending patch
Thanks, applied to perf/urgent.
- Arnaldo
next prev parent reply other threads:[~2019-02-04 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 13:53 [RFC] perf tools: Filter out hidden symbols from labels Jiri Olsa
2019-01-15 16:13 ` Nick Clifton
2019-01-15 16:35 ` Arnaldo Carvalho de Melo
2019-01-16 4:37 ` Namhyung Kim
2019-01-16 11:38 ` Nick Clifton
2019-01-16 13:31 ` Arnaldo Carvalho de Melo
2019-01-16 15:47 ` Nick Clifton
2019-01-16 16:04 ` Arnaldo Carvalho de Melo
2019-01-17 10:25 ` Nick Clifton
2019-01-17 13:26 ` Arnaldo Carvalho de Melo
2019-01-15 17:38 ` [RFCv2] " Jiri Olsa
2019-01-28 13:35 ` [PATCH] " Jiri Olsa
2019-01-29 9:07 ` Arnaldo Carvalho de Melo
2019-01-29 11:25 ` Nick Clifton
2019-01-29 11:39 ` Arnaldo Carvalho de Melo
2019-01-29 12:57 ` Nick Clifton
2019-01-29 12:58 ` Nick Clifton
2019-02-04 14:45 ` Arnaldo Carvalho de Melo [this message]
2019-02-09 12:22 ` [tip:perf/urgent] perf symbols: " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204144547.GG5593@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).