From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: s-anna@ti.com, nsekhar@ti.com, linux-omap@vger.kernel.org,
t-kristo@ti.com, nsaulnier@ti.com, jreeder@ti.com,
m-karicheri2@ti.com, david@lechnology.com,
woods.technical@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ARM: dts: dra7: add PRU-ICSS modules
Date: Mon, 4 Feb 2019 10:03:59 -0800 [thread overview]
Message-ID: <20190204180359.GM5720@atomide.com> (raw)
In-Reply-To: <1549295637-24890-4-git-send-email-rogerq@ti.com>
* Roger Quadros <rogerq@ti.com> [190204 15:54]:
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -167,6 +167,200 @@
> l4_per3: interconnect@48800000 {
> };
>
> + pru_icss1: target-module@4b200000 {
I suggest you add these into dra7-pruss.dtsi as they
have internal interconnects. And eventually some of
the *pruss.dtsi files might become shared :) And we
avoid moving these around when we define the l3
interconnects and avoid a lot of extra long dtsi
line lengths with the added nestedness later on.
Regards,
Tony
next prev parent reply other threads:[~2019-02-04 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 15:53 [PATCH 0/4] AM57xx: PRU ICSS Support Roger Quadros
2019-02-04 15:53 ` [PATCH 1/4] dt-binding: bus: ti-sysc: Add support for PRUSS SYSC type Roger Quadros
2019-02-04 15:53 ` [PATCH 2/4] " Roger Quadros
2019-02-04 18:00 ` Tony Lindgren
2019-02-11 12:11 ` Roger Quadros
2019-02-25 21:26 ` Rob Herring
2019-02-25 21:30 ` Suman Anna
2019-02-26 14:16 ` Roger Quadros
2019-02-04 15:53 ` [PATCH 3/4] ARM: dts: dra7: add PRU-ICSS modules Roger Quadros
2019-02-04 18:03 ` Tony Lindgren [this message]
2019-03-29 14:02 ` Roger Quadros
2019-04-01 14:30 ` Tony Lindgren
2019-02-04 15:53 ` [PATCH 4/4] ARM: dts: am57xx-idk-common: Enable PRU-ICSS nodes Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204180359.GM5720@atomide.com \
--to=tony@atomide.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=jreeder@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=nsaulnier@ti.com \
--cc=nsekhar@ti.com \
--cc=rogerq@ti.com \
--cc=s-anna@ti.com \
--cc=t-kristo@ti.com \
--cc=woods.technical@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).