From: Sven Van Asbroeck <thesven73@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Kees Cook <keescook@chromium.org>
Subject: [RFC v1 0/3] Address potential user-after-free on module unload
Date: Mon, 4 Feb 2019 17:09:49 -0500
Message-ID: <20190204220952.30761-1-TheSven73@googlemail.com> (raw)
I think there _might_ be potential use-after-free issues on module unload.
They are hard to trigger, but I think I've seen them bring the whole
kernel down when they do occur. Can be triggered by doing an insmod of
a vulnerable module, rapidly followed by an rmmod.
Caused by drivers which schedule work / delayed_work, but do not clean it up
properly on module unload. Which means the work function could run _after_
the module has unloaded.
A quick grep through the kernel sources brings up many instances.
I leave it to people more knowledgeable than me to determine if this problem
is likely to happen, and/or if it can be exploited to become a security risk.
Perhaps developers can be 'nudged' into doing the right thing by using
resource-managed versions of INIT_WORK() / INIT_DELAYED_WORK(), which may
address the issue quite elegantly.
Attached is a proposal patch, followed by sample fixes for two vulnerable
modules. As far as I can tell, many more modules are vulnerable.
Sven Van Asbroeck (3):
workqueue: Add resource-managed version of INIT_[DELAYED_]WORK()
max17042_battery: fix potential user-after-free on module unload
cap11xx: fix potential user-after-free on module unload
drivers/input/keyboard/cap11xx.c | 6 ++-
drivers/power/supply/max17042_battery.c | 5 ++-
include/linux/workqueue.h | 7 ++++
kernel/workqueue.c | 54 +++++++++++++++++++++++++
4 files changed, 70 insertions(+), 2 deletions(-)
--
2.17.1
next reply index
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 22:09 Sven Van Asbroeck [this message]
2019-02-04 22:09 ` [RFC v1 1/3] workqueue: Add resource-managed version of INIT_[DELAYED_]WORK() Sven Van Asbroeck
2019-02-08 17:06 ` Tejun Heo
2019-02-08 18:15 ` Sven Van Asbroeck
2019-02-04 22:09 ` [RFC v1 2/3] max17042_battery: fix potential user-after-free on module unload Sven Van Asbroeck
2019-02-05 8:27 ` Dmitry Torokhov
2019-02-05 14:27 ` Sven Van Asbroeck
2019-02-05 17:21 ` Sebastian Reichel
2019-02-04 22:09 ` [RFC v1 3/3] cap11xx: " Sven Van Asbroeck
2019-02-05 8:18 ` Dmitry Torokhov
2019-02-05 8:34 ` Dmitry Torokhov
2019-02-05 21:24 ` Jacek Anaszewski
2019-02-05 21:43 ` Dmitry Torokhov
2019-02-05 22:03 ` Sven Van Asbroeck
2019-02-05 14:57 ` [RFC v1 0/3] Address " Kees Cook
2019-02-05 15:22 ` Sven Van Asbroeck
2019-02-05 18:43 ` Greg KH
2019-02-05 19:12 ` Sven Van Asbroeck
2019-02-06 16:46 ` Greg KH
2019-02-06 17:30 ` Dmitry Torokhov
2019-02-06 17:49 ` Sven Van Asbroeck
2019-02-08 6:51 ` Greg KH
2019-02-05 18:42 ` Greg KH
2019-02-07 21:49 ` Sven Van Asbroeck
2019-02-07 22:20 ` Dmitry Torokhov
2019-02-07 22:27 ` Sven Van Asbroeck
2019-02-07 22:32 ` Sven Van Asbroeck
2019-02-07 22:48 ` Dmitry Torokhov
2019-02-08 4:30 ` Miguel Ojeda
2019-02-10 18:05 ` Sven Van Asbroeck
2019-02-14 1:11 ` Miguel Ojeda
2019-02-14 15:23 ` Sven Van Asbroeck
[not found] ` <CAGngYiXcogd69n-MvBD1n5ZJpBzqCau8UOfLMgXEXLnAev=srw@mail.gmail.com>
[not found] ` <alpine.DEB.2.21.1902080745480.4201@hadrien>
2019-02-14 17:52 ` Fwd: " Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204220952.30761-1-TheSven73@googlemail.com \
--to=thesven73@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
linux-kernel@vger.kernel.org
public-inbox-index lkml
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git