LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Nicolas Dechesne <nicolas.dechesne@linaro.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Andy Gross <andy.gross@linaro.org>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	lkml <linux-kernel@vger.kernel.org>,
	linux-rockchip@lists.infradead.org,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	linux-soc@vger.kernel.org,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Amit Kucheria <amit.kucheria@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Koen Kooi <koen.kooi@linaro.org>
Subject: Re: [PATCH v3 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels
Date: Tue, 5 Feb 2019 11:24:12 -0800
Message-ID: <20190205192412.GG31919@minitux> (raw)
In-Reply-To: <CAP71WjzWiCg-NXDnh58N-5O7kvNj+DDndSK04DeoPxFE2L8W0g@mail.gmail.com>

On Tue 05 Feb 11:00 PST 2019, Nicolas Dechesne wrote:

> Hey Mani,
> 
> thanks for sending this out, it should have been just like that in the
> first place ;)
> 

Thanks Nico for the confirmation, I will queue this for v5.2

Regards,
Bjorn

> On Fri, Dec 21, 2018 at 3:36 AM Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
> >
> > On Mon, Oct 29, 2018 at 03:12:45PM +0530, Manivannan Sadhasivam wrote:
> > > For all 96Boards, the following standard is used for onboard LEDs.
> > >
> > > green:user1  default-trigger: heartbeat
> > > green:user2  default-trigger: mmc0/disk-activity(onboard-storage)
> > > green:user3  default-trigger: mmc1 (SD-card)
> > > green:user4  default-trigger: none, panic-indicator
> > > yellow:wlan  default-trigger: phy0tx
> > > blue:bt      default-trigger: hci0-power
> > >
> > > So lets adopt the same for APQ8016 SBC (Dragonboard410c), which is
> > > one of the 96Boards CE platform.
> > >
> >
> > Hello,
> >
> > Any update on this patch?
> 
> Reviewed-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
> 
> >
> > Regards,
> > Mani
> >
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
> > > ---
> > >  arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 ++++++------
> > >  1 file changed, 6 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > > index 46feedf7c989..35f95154316b 100644
> > > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > > @@ -300,28 +300,28 @@
> > >                       compatible = "gpio-leds";
> > >
> > >                       led@1 {
> > > -                             label = "apq8016-sbc:green:user1";
> > > +                             label = "green:user1";
> > >                               gpios = <&msmgpio 21 GPIO_ACTIVE_HIGH>;
> > >                               linux,default-trigger = "heartbeat";
> > >                               default-state = "off";
> > >                       };
> > >
> > >                       led@2 {
> > > -                             label = "apq8016-sbc:green:user2";
> > > +                             label = "green:user2";
> > >                               gpios = <&msmgpio 120 GPIO_ACTIVE_HIGH>;
> > >                               linux,default-trigger = "mmc0";
> > >                               default-state = "off";
> > >                       };
> > >
> > >                       led@3 {
> > > -                             label = "apq8016-sbc:green:user3";
> > > +                             label = "green:user3";
> > >                               gpios = <&pm8916_gpios 1 GPIO_ACTIVE_HIGH>;
> > >                               linux,default-trigger = "mmc1";
> > >                               default-state = "off";
> > >                       };
> > >
> > >                       led@4 {
> > > -                             label = "apq8016-sbc:green:user4";
> > > +                             label = "green:user4";
> > >                               gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
> > >                               linux,default-trigger = "none";
> > >                               panic-indicator;
> > > @@ -329,14 +329,14 @@
> > >                       };
> > >
> > >                       led@5 {
> > > -                             label = "apq8016-sbc:yellow:wlan";
> > > +                             label = "yellow:wlan";
> > >                               gpios = <&pm8916_mpps 2 GPIO_ACTIVE_HIGH>;
> > >                               linux,default-trigger = "phy0tx";
> > >                               default-state = "off";
> > >                       };
> > >
> > >                       led@6 {
> > > -                             label = "apq8016-sbc:blue:bt";
> > > +                             label = "blue:bt";
> > >                               gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>;
> > >                               linux,default-trigger = "bluetooth-power";
> > >                               default-state = "off";
> > > --
> > > 2.17.1
> > >

  reply index

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29  9:42 [PATCH v3 0/7] Standardize onboard LED support for 96Boards Manivannan Sadhasivam
2018-10-29  9:42 ` [PATCH v3 1/7] arm64: dts: rockchip: ficus: Add on-board LED support Manivannan Sadhasivam
2018-12-11 19:11   ` Heiko Stuebner
2018-10-29  9:42 ` [PATCH v3 2/7] arm64: dts: rockchip: rock960: " Manivannan Sadhasivam
2018-12-11 19:11   ` Heiko Stuebner
2018-10-29  9:42 ` [PATCH v3 3/7] arm64: dts: hisilicon: hikey: Standardize LED labels and triggers Manivannan Sadhasivam
2018-10-29  9:42 ` [PATCH v3 4/7] arm64: dts: hisilicon: hikey960: " Manivannan Sadhasivam
2018-10-29  9:42 ` [PATCH v3 5/7] arm64: dts: hisilicon: poplar: " Manivannan Sadhasivam
2018-10-29  9:42 ` [PATCH v3 6/7] arm64: dts: xilinx: ultra96: " Manivannan Sadhasivam
2018-12-21  2:37   ` Manivannan Sadhasivam
2018-12-21  6:50     ` Michal Simek
2019-01-24 16:49       ` Rob Herring
2019-01-29 13:17         ` Michal Simek
2018-10-29  9:42 ` [PATCH v3 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels Manivannan Sadhasivam
2018-12-21  2:35   ` Manivannan Sadhasivam
2019-02-05 19:00     ` Nicolas Dechesne
2019-02-05 19:24       ` Bjorn Andersson [this message]
2018-10-31 13:38 ` [PATCH v3 0/7] Standardize onboard LED support for 96Boards Linus Walleij
     [not found]   ` <CAHTX3dJTXtuA0i-ffPjoiWuxEcF_5JY55VJtWd9zxW4HxK1K3w@mail.gmail.com>
2018-10-31 21:17     ` Linus Walleij
2018-11-01 10:49       ` Heiko Stübner
2018-11-29 15:42   ` Wei Xu

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190205192412.GG31919@minitux \
    --to=bjorn.andersson@linaro.org \
    --cc=amit.kucheria@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=koen.kooi@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=nicolas.dechesne@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git