From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E17C282CB for ; Tue, 5 Feb 2019 20:48:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CF6F2083B for ; Tue, 5 Feb 2019 20:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549399735; bh=vYWzqUBHb0lsDz99Ph6B4J3PPiJp6dXjUg535knJYPs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1D1wclMuTWqD+uFC3SwuXsEhe8ZPPipy/rnPAb7JrOkv1DKTMYaB9Icc0FSeTDl8x DcPbgp/Pc9t2AcqqP3H/WtN16+qt1gdy/ps9qef87K23JOh9zkjsCkI5FO3lnAOsEW BW+W7Me1/NDvx8WmTAXeI2T5yzfzJV4YXUNXERNk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728993AbfBEUsx (ORCPT ); Tue, 5 Feb 2019 15:48:53 -0500 Received: from mail-yw1-f65.google.com ([209.85.161.65]:35275 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727000AbfBEUsx (ORCPT ); Tue, 5 Feb 2019 15:48:53 -0500 Received: by mail-yw1-f65.google.com with SMTP id j82so2280471ywb.2; Tue, 05 Feb 2019 12:48:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=90bUQv9LA5iJfhNHV44B1JZLLZtsVUwl0LFGm8mDW8U=; b=UeiXHi80PGFxwZTW28+KIOgjfxUYl7dh8oKoKALNkQd10i2dcx9xjW6ft8vruAos0x mqKxAODEG+tR52lsB5nm11q6uWqriOI/PURa4aUbEX8qkWXYusUGGmfhTvx/c2Idttro h5SIA9kwtq272eMbjBaQF3QvtuEqc+mtuLnOy+LQLr3cA2+NtEoS9ujxWYB5W3+uqtav Fw8Sp8fWqwlP6M0JxIuFDXlD4lBHtAgt9A/NCgqeGLpR2skZFKm/xQSeSHJZGaEyYLcq bpuSZGcflRUa1o3v8YChJJQ6SQJoaq8zGuiswN/bDo1IE0raaX+9/sRGZf85JThjtFYY uoLw== X-Gm-Message-State: AHQUAuYQcASRFBXbzg3SRGXLlX1I22DX/UgN/emqtDLnKk7tVdv0bq3F bKhLtJo8VPsaSwEVy0AXwOI= X-Google-Smtp-Source: AHgI3IZNUXWH8Lvr2tTUFbo9dxtxRsYxey+5QG/61gjWrJ7F77VoAwQ4iIpbv/zncOHcliVji5Xk3A== X-Received: by 2002:a81:78d7:: with SMTP id t206mr5665305ywc.361.1549399731830; Tue, 05 Feb 2019 12:48:51 -0800 (PST) Received: from dennisz-mbp.dhcp.thefacebook.com ([2620:10d:c091:200::6:6d9d]) by smtp.gmail.com with ESMTPSA id b11sm1794031ywb.0.2019.02.05.12.48.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Feb 2019 12:48:50 -0800 (PST) Date: Tue, 5 Feb 2019 15:48:48 -0500 From: Dennis Zhou To: Dennis Zhou Cc: David Sterba , David Sterba , Josef Bacik , Chris Mason , Omar Sandoval , Nick Terrell , Nikolay Borisov , kernel-team@fb.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 00/12] btrfs: add zstd compression level support Message-ID: <20190205204848.GA39186@dennisz-mbp.dhcp.thefacebook.com> References: <20190204202008.51652-1-dennis@kernel.org> <20190205145753.GR2900@twin.jikos.cz> <20190205160302.GA89375@dennisz-mbp> <20190205162733.GT2900@suse.cz> <20190205163012.GB89375@dennisz-mbp> <20190205165113.GU2900@suse.cz> <20190205170749.GV2900@suse.cz> <20190205182748.GY2900@twin.jikos.cz> <20190205183027.GA17870@dennisz-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190205183027.GA17870@dennisz-mbp.dhcp.thefacebook.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 05, 2019 at 01:30:27PM -0500, Dennis Zhou wrote: > On Tue, Feb 05, 2019 at 07:27:49PM +0100, David Sterba wrote: > > On Tue, Feb 05, 2019 at 06:07:49PM +0100, David Sterba wrote: > > > On Tue, Feb 05, 2019 at 05:51:13PM +0100, David Sterba wrote: > > > > On Tue, Feb 05, 2019 at 11:30:12AM -0500, Dennis Zhou wrote: > > > > > > > > Something is wrong, the patchset on top of 5.0-rc5 hangs in test > > > > > > > > btrfs/007, without a stacktrace. V1 was fine and I double checked that > > > > > > > > rc5 itself is fine. > > > > > > > > > > > > > > Hmmm, well that's awkward. I ran xfstests and that test passed on my > > > > > > > machine. I'll figure out the delta and submit a v3. Thanks David! > > > > > > > > > > > > It failed on a VM and 2 other physical machines, so it's not somethig > > > > > > related to the testing setup. > > > > > > > > > > Oh, I wasn't alluding to that. I'm more that sure it's my fault > > > > > somewhere along the line. > > > > > > > > Hang on, it's probably caused by fstests, as fssum is busy waiting > > > > somewhere, so it's not even kernel code. > > > > > > > > fstests a4235f29f780b15d9e87c0f2446a53b9e69c5e2d -- ok > > > > fstests 6d17c9076fe9d97d2411e5909e6b255e5e721fc3 (master) -- hangs > > > > > > Git bisect points to > > > > > > commit 04b405fa1f8d0cacde489f3d1c8771dfe7a34dc0 > > > Author: Zorro Lang > > > Date: Wed Jan 23 15:34:55 2019 +0800 > > > > > > common/dump: disable splice from FSSTRESS_AVOID > > > > So with this commit reverted, test btrfs/007 does not hang anymore. > > Ok great! I'm going to add a v2 for 0012 to add taking the spin_lock > just to be safe in cleanup. I should have that ready in a few minutes. > Before I run v3, are there any other concerns (pending the changes I made to address the mentioned make sense)? Thanks, Dennis