From: jackm <jackm@dev.mellanox.co.il>
To: "Håkon Bugge" <haakon.bugge@oracle.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
netdev@vger.kernel.org,
OFED mailing list <linux-rdma@vger.kernel.org>,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mlx4_ib: Increase the timeout for CM cache
Date: Wed, 6 Feb 2019 20:02:29 +0200 [thread overview]
Message-ID: <20190206200229.00002e2f@dev.mellanox.co.il> (raw)
In-Reply-To: <FF460501-80BA-44B9-AD59-84F64A338D67@oracle.com>
On Wed, 6 Feb 2019 16:40:14 +0100
Håkon Bugge <haakon.bugge@oracle.com> wrote:
> Jack,
>
> A major contributor to the long processing time in the PF driver
> proxying QP1 packets is:
>
> create_pv_resources
> -> ib_create_cq(ctx->ib_dev, mlx4_ib_tunnel_comp_handler,
> NULL, ctx, cq_size, 0);
>
> That is, comp_vector is zero.
>
> Due to commit 6ba1eb776461 ("IB/mlx4: Scatter CQs to different EQs"),
> the zero comp_vector has the intent of let the mlx4_core driver
> select the least used vector.
>
> But, in mlx4_ib_create_cq(), we have:
>
> pr_info("eq_table: %p\n", dev->eq_table);
> if (dev->eq_table) {
> vector = dev->eq_table[mlx4_choose_vector(dev->dev,
> vector, ibdev->num_comp_vectors)];
> }
>
> cq->vector = vector;
>
> and dev->eq_table is NULL, so all the CQs for the proxy QPs get
> comp_vector zero.
>
> I have to make some reservations, as this analysis is based on uek4,
> but I think the code here is equal upstream, but need to double check.
>
>
> Thxs, Håkon
>
Hi Hakon and Jason,
I was ill today (bad cold, took antihistamines all day, which knocked
me out).
I'll get to this tomorrow.
-Jack
prev parent reply other threads:[~2019-02-06 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 17:09 [PATCH] mlx4_ib: Increase the timeout for CM cache Håkon Bugge
2019-02-01 15:18 ` Håkon Bugge
2019-02-05 22:36 ` Jason Gunthorpe
2019-02-06 8:50 ` Håkon Bugge
2019-02-06 15:40 ` Håkon Bugge
2019-02-06 18:02 ` jackm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206200229.00002e2f@dev.mellanox.co.il \
--to=jackm@dev.mellanox.co.il \
--cc=haakon.bugge@oracle.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).