From: Tony Lindgren <tony@atomide.com>
To: Johan Hovold <johan@kernel.org>
Cc: Andreas Kemnade <andreas@kemnade.info>,
mark.rutland@arm.com, devicetree@vger.kernel.org,
letux-kernel@openphoenux.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, bcousson@baylibre.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 2/2] arm: dts: gta04: add gps support
Date: Thu, 7 Feb 2019 09:31:31 -0800 [thread overview]
Message-ID: <20190207173131.GF5720@atomide.com> (raw)
In-Reply-To: <20190204083032.GB4686@localhost>
* Johan Hovold <johan@kernel.org> [190204 08:30]:
> On Fri, Feb 01, 2019 at 08:06:30PM +0100, Andreas Kemnade wrote:
> > On Fri, 1 Feb 2019 11:04:16 +0100
> > Johan Hovold <johan@kernel.org> wrote:
> >
> > > On Thu, Jan 31, 2019 at 07:06:40PM +0100, Andreas Kemnade wrote:
> > > > The GTA04 has a w2sg0004 or w2sg0084 gps chip. Not detectable
> > > > which one is mounted so use the compatibility entry for w2sg0004
> > > > for all which will work for both.
> > > >
> > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > > ---
> > > > Changes in v3:
> > > > - converted to a patchset
> > > > - added vcc-supply
> > > >
> > > > Changes in v2:
> > > > - some s/gps/gnss/
> > > > - not added vcc-supply because the regulator is not modelled
> > > > in dts at all
> > > >
> > > > w2sg0004 bindings are in next-20190129
> > > >
> > > > arch/arm/boot/dts/omap3-gta04.dtsi | 14 ++++++++++++++
> > > > 1 file changed, 14 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> > > > index 02d8274a2f47..4ea0f7dc37c6 100644
> > > > --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> > > > +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> > > > @@ -320,6 +320,12 @@
> > > > >;
> > > > };
> > > >
> > > > + gps_pins: pinmux_gps_pins {
> > >
> > > s/gps/gnss/ would be more consistent, but whatever.
> > >
> > well, gps is already in the file at another place. So it is a bit
> > inconsistent in any case, without further cleanup. If someone comes
> > up with a strong opinion here I would of course change it.
>
> Up to you. As long as the gnss node is named "gnss" I don't have a
> strong opinion on the other names (as long as they follow the spec of
> course).
OK so I'm applying these two patches into omap-for-v5.1/dt.
Thanks,
Tony
prev parent reply other threads:[~2019-02-07 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 18:06 [PATCH v3 0/2] arm: dts: gta04: add gps support Andreas Kemnade
2019-01-31 18:06 ` [PATCH v3 1/2] arm: dts: gta04: add ldo 3v3 regulator Andreas Kemnade
2019-02-01 10:02 ` Johan Hovold
2019-01-31 18:06 ` [PATCH v3 2/2] arm: dts: gta04: add gps support Andreas Kemnade
2019-02-01 10:04 ` Johan Hovold
2019-02-01 19:06 ` Andreas Kemnade
2019-02-01 20:09 ` [Letux-kernel] " H. Nikolaus Schaller
2019-02-04 8:30 ` Johan Hovold
2019-02-07 17:31 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207173131.GF5720@atomide.com \
--to=tony@atomide.com \
--cc=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).