* linux-next: build warning after merge of the crypto tree
@ 2019-02-04 0:01 Stephen Rothwell
2019-02-08 7:04 ` [PATCH] crypto: qat - Remove unused goto label Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2019-02-04 0:01 UTC (permalink / raw)
To: Herbert Xu
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Greg Kroah-Hartman
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
Hi Herbert,
After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/crypto/qat/qat_common/adf_transport.c: In function 'adf_init_etr_data':
drivers/crypto/qat/qat_common/adf_transport.c:501:1: warning: label 'err_bank_debug' defined but not used [-Wunused-label]
err_bank_debug:
^~~~~~~~~~~~~~
Introduced by commit
f0fcf9ade46a ("crypto: qat - no need to check return value of debugfs_create functions")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] crypto: qat - Remove unused goto label
2019-02-04 0:01 linux-next: build warning after merge of the crypto tree Stephen Rothwell
@ 2019-02-08 7:04 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-02-08 7:04 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Greg Kroah-Hartman, Linux Crypto Mailing List
On Mon, Feb 04, 2019 at 11:01:06AM +1100, Stephen Rothwell wrote:
> Hi Herbert,
>
> After merging the crypto tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/crypto/qat/qat_common/adf_transport.c: In function 'adf_init_etr_data':
> drivers/crypto/qat/qat_common/adf_transport.c:501:1: warning: label 'err_bank_debug' defined but not used [-Wunused-label]
> err_bank_debug:
> ^~~~~~~~~~~~~~
>
> Introduced by commit
>
> f0fcf9ade46a ("crypto: qat - no need to check return value of debugfs_create functions")
Thanks for the report Stephen!
---8<---
This patch removes an unused label.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: f0fcf9ade46a ("crypto: qat - no need to check return...")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/drivers/crypto/qat/qat_common/adf_transport.c b/drivers/crypto/qat/qat_common/adf_transport.c
index ac658ce46836..2136cbe4bf6c 100644
--- a/drivers/crypto/qat/qat_common/adf_transport.c
+++ b/drivers/crypto/qat/qat_common/adf_transport.c
@@ -498,7 +498,6 @@ int adf_init_etr_data(struct adf_accel_dev *accel_dev)
err_bank_all:
debugfs_remove(etr_data->debug);
-err_bank_debug:
kfree(etr_data->banks);
err_bank:
kfree(etr_data);
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-08 7:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-04 0:01 linux-next: build warning after merge of the crypto tree Stephen Rothwell
2019-02-08 7:04 ` [PATCH] crypto: qat - Remove unused goto label Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).