From: "Michael S. Tsirkin" <mst@redhat.com>
To: Mike Rapoport <rppt@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 0/3] generic asm: mman cleanup
Date: Fri, 8 Feb 2019 16:19:07 -0500 [thread overview]
Message-ID: <20190208161820-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190208181246.GF11096@rapoport-lnx>
On Fri, Feb 08, 2019 at 08:12:47PM +0200, Mike Rapoport wrote:
> On Fri, Feb 08, 2019 at 01:02:51AM -0500, Michael S. Tsirkin wrote:
> > Now that we have MAP_SHARED, MAP_PRIVATE and MAP_SHARED_VALIDATE on all
> > architectures, it probably makes sense to de-duplicate these
> > and put them into a common header.
>
> I like the idea, but it seems there are more asm/mman.h users than just mpx
> and drm.
>
> Any reason only those were updated to include linux/mman.h?
They are all .c files. So since they keep building I know
nothing else will break. Fixing them would be an unrelated
cleanup.
>
> > Please review and consider merging though the generic tree.
> >
> > Build tested on x86 only. Has been in linux-next for a while now.
> >
> > Michael S. Tsirkin (3):
> > x86/mpx: tweak header name
> > drm: tweak header name
> > arch: move common mmap flags to linux/mman.h
> >
> > arch/alpha/include/uapi/asm/mman.h | 4 +---
> > arch/mips/include/uapi/asm/mman.h | 4 +---
> > arch/parisc/include/uapi/asm/mman.h | 4 +---
> > arch/x86/mm/mpx.c | 2 +-
> > arch/xtensa/include/uapi/asm/mman.h | 4 +---
> > include/drm/drmP.h | 3 +--
> > include/uapi/asm-generic/mman-common.h | 4 +---
> > include/uapi/linux/mman.h | 4 ++++
> > 8 files changed, 11 insertions(+), 18 deletions(-)
> >
> > --
> > MST
> >
>
> --
> Sincerely yours,
> Mike.
next prev parent reply other threads:[~2019-02-08 21:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 6:02 [PATCH 0/3] generic asm: mman cleanup Michael S. Tsirkin
2019-02-08 6:02 ` [PATCH 1/3] x86/mpx: tweak header name Michael S. Tsirkin
2019-02-08 15:42 ` Borislav Petkov
2019-02-08 21:43 ` Michael S. Tsirkin
2019-02-08 21:50 ` Dave Hansen
2019-02-08 21:52 ` Borislav Petkov
2019-02-10 0:20 ` Michael S. Tsirkin
2019-02-08 6:02 ` [PATCH 2/2] arch: move common mmap flags to linux/mman.h Michael S. Tsirkin
2019-02-08 6:02 ` [PATCH 2/3] drm: tweak header name Michael S. Tsirkin
2019-02-08 8:56 ` Daniel Vetter
2019-02-08 12:55 ` Michael S. Tsirkin
2019-02-08 6:03 ` [PATCH 3/3] arch: move common mmap flags to linux/mman.h Michael S. Tsirkin
2019-02-08 18:12 ` [PATCH 0/3] generic asm: mman cleanup Mike Rapoport
2019-02-08 21:19 ` Michael S. Tsirkin [this message]
2019-02-11 4:20 ` Michael S. Tsirkin
2019-02-18 14:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208161820-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).