From: Will Deacon <will.deacon@arm.com>
To: AngeloGioacchino Del Regno <kholk11@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] arm64/io: Don't use WZR in writel
Date: Mon, 11 Feb 2019 10:57:55 +0000 [thread overview]
Message-ID: <20190211105755.GB30880@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <68b71c15f32341468a868f6418e4fcb375bc49ba.camel@gmail.com>
On Sat, Feb 09, 2019 at 07:34:53PM +0100, AngeloGioacchino Del Regno wrote:
> From 33fb6d036de273bb71ac1c67d7a91b7a5148e659 Mon Sep 17 00:00:00 2001
> From: "Angelo G. Del Regno" <kholk11@gmail.com>
> Date: Sat, 9 Feb 2019 18:56:46 +0100
> Subject: [PATCH] arm64/io: Don't use WZR in writel
>
> This is a partial revert of commit ee5e41b5f21a
> ("arm64/io: Allow I/O writes to use {W,X}ZR")
>
> When we try to use the zero register directly on some SoCs,
> their security will make them freeze due to a firmware bug.
> This behavior is seen with the arm-smmu driver freezing on
> TLBI and TLBSYNC on MSM8996, MSM8998, SDM630, SDM660.
Hmm, this sounds very fragile. I hope they're not trapping and emulating
MMIO accesses and treating the zero register as the stack pointer...
Wouldn't this also be triggerable from userspace by mmap()ing either
/dev/mem or e.g. a PCI bar via sysfs?
> Allocating a temporary register to store the zero for the
> write actually solves the issue on these SoCs.
I don't think this catches all MMIO accesses, so I think we need to
understand more about the actual issue here. For example, is it only the
SMMU that causes this problem? Also, any workaround should be specific to
the broken SoCs.
Will
next prev parent reply other threads:[~2019-02-11 10:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 18:34 [PATCH] arm64/io: Don't use WZR in writel AngeloGioacchino Del Regno
2019-02-11 10:57 ` Will Deacon [this message]
2019-02-11 11:52 ` Marc Zyngier
2019-02-11 14:29 ` AngeloGioacchino Del Regno
2019-02-11 14:59 ` Marc Zyngier
2019-02-11 16:15 ` AngeloGioacchino Del Regno
2019-02-11 16:37 ` Robin Murphy
2019-02-23 18:12 ` Bjorn Andersson
2019-02-23 18:37 ` Marc Zyngier
2019-02-24 3:53 ` Bjorn Andersson
2019-03-12 12:36 ` Marc Gonzalez
2019-03-18 16:04 ` Robin Murphy
2019-03-18 17:00 ` Russell King - ARM Linux admin
2019-03-18 17:11 ` Ard Biesheuvel
2019-03-18 17:19 ` Robin Murphy
2019-03-18 17:24 ` Robin Murphy
2019-03-19 11:45 ` Robin Murphy
2019-03-18 17:30 ` Marc Gonzalez
2019-03-18 17:59 ` Robin Murphy
-- strict thread matches above, loose matches on Subject: below --
2019-02-09 18:30 AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211105755.GB30880@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=axboe@kernel.dk \
--cc=catalin.marinas@arm.com \
--cc=kholk11@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).