From: Mark Rutland <mark.rutland@arm.com>
To: Torsten Duwe <duwe@lst.de>
Cc: Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Julien Thierry <julien.thierry@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Amit Daniel Kachhap <amit.kachhap@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
Subject: Re: [PATCH v8 1/5] arm64: replace -pg with CC_FLAGS_FTRACE in arm64 Makefiles
Date: Mon, 11 Feb 2019 11:53:01 +0000 [thread overview]
Message-ID: <20190211115300.GA10501@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20190208151007.276E968DD2@newverein.lst.de>
On Fri, Feb 08, 2019 at 04:10:07PM +0100, Torsten Duwe wrote:
> In preparation for arm64 supporting ftrace built on other compiler
> options, let's have the arm64 makefiles remove the $(CC_FLAGS_FTRACE)
> flags, whatever these may be, rather than assuming '-pg'.
>
> There should be no functional change as a result of this patch.
>
> Signed-off-by: Torsten Duwe <duwe@suse.de>
Thanks for splitting this out.
With the indentation removed from the commit text:
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
>
> ---
> arch/arm64/kernel/Makefile | 6 +++---
> arch/arm64/lib/Makefile | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
> --- a/arch/arm64/kernel/Makefile
> +++ b/arch/arm64/kernel/Makefile
> @@ -7,9 +7,9 @@ CPPFLAGS_vmlinux.lds := -DTEXT_OFFSET=$(
> AFLAGS_head.o := -DTEXT_OFFSET=$(TEXT_OFFSET)
> CFLAGS_armv8_deprecated.o := -I$(src)
>
> -CFLAGS_REMOVE_ftrace.o = -pg
> -CFLAGS_REMOVE_insn.o = -pg
> -CFLAGS_REMOVE_return_address.o = -pg
> +CFLAGS_REMOVE_ftrace.o = $(CC_FLAGS_FTRACE)
> +CFLAGS_REMOVE_insn.o = $(CC_FLAGS_FTRACE)
> +CFLAGS_REMOVE_return_address.o = $(CC_FLAGS_FTRACE)
>
> # Object file lists.
> obj-y := debug-monitors.o entry.o irq.o fpsimd.o \
> --- a/arch/arm64/lib/Makefile
> +++ b/arch/arm64/lib/Makefile
> @@ -24,7 +24,7 @@ CFLAGS_atomic_ll_sc.o := -ffixed-x1 -ffi
> -fcall-saved-x10 -fcall-saved-x11 -fcall-saved-x12 \
> -fcall-saved-x13 -fcall-saved-x14 -fcall-saved-x15 \
> -fcall-saved-x18 -fomit-frame-pointer
> -CFLAGS_REMOVE_atomic_ll_sc.o := -pg
> +CFLAGS_REMOVE_atomic_ll_sc.o := $(CC_FLAGS_FTRACE)
> GCOV_PROFILE_atomic_ll_sc.o := n
> KASAN_SANITIZE_atomic_ll_sc.o := n
> KCOV_INSTRUMENT_atomic_ll_sc.o := n
next prev parent reply other threads:[~2019-02-11 11:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 15:08 [PATCH v8 0/5] arm64: ftrace with regs Torsten Duwe
2019-02-08 15:10 ` [PATCH v8 1/5] arm64: replace -pg with CC_FLAGS_FTRACE in arm64 Makefiles Torsten Duwe
2019-02-11 11:53 ` Mark Rutland [this message]
2019-02-08 15:10 ` [PATCH v8 2/5] arm64: replace -pg with CC_FLAGS_FTRACE in efi Makefiles Torsten Duwe
2019-02-11 11:59 ` Mark Rutland
2019-04-08 15:23 ` Mark Rutland
2019-04-08 20:49 ` Ard Biesheuvel
2019-02-08 15:10 ` [PATCH v8 3/5] arm64: replace -pg with CC_FLAGS_FTRACE in mm/kasan Makefile Torsten Duwe
2019-02-11 11:55 ` Mark Rutland
2019-02-11 11:56 ` Mark Rutland
2019-04-08 15:25 ` Mark Rutland
2019-04-08 15:35 ` Andrey Ryabinin
2019-02-08 15:10 ` [PATCH v8 4/5] arm64: implement ftrace with regs Torsten Duwe
2019-02-13 10:30 ` Julien Thierry
2019-02-08 15:10 ` [PATCH v8 5/5] arm64: use -fpatchable-function-entry if available Torsten Duwe
2019-02-13 11:11 ` [PATCH v8 0/5] arm64: ftrace with regs Julien Thierry
2019-03-11 11:49 ` Torsten Duwe
2019-03-11 12:18 ` Mark Rutland
2019-03-29 10:18 ` Torsten Duwe
2019-04-08 15:36 ` Mark Rutland
2019-04-09 17:52 ` Will Deacon
2019-07-10 12:27 ` Ruslan Bilovol
2019-07-24 16:15 ` Mark Rutland
2019-10-16 11:42 ` Jiri Kosina
2019-10-16 17:58 ` Mark Rutland
2019-10-18 17:41 ` Mark Rutland
2019-10-19 11:01 ` Torsten Duwe
2019-10-21 11:37 ` Mark Rutland
2019-10-21 13:20 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211115300.GA10501@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=amit.kachhap@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=duwe@lst.de \
--cc=jpoimboe@redhat.com \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).