From: Sudeep Holla <sudeep.holla@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Dave Gerlach <d-gerlach@ti.com>, Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH 0/2] cpufreq/opp: rework regulator initialization
Date: Mon, 11 Feb 2019 14:08:29 +0000 [thread overview]
Message-ID: <20190211140829.GA4269@e107155-lin> (raw)
In-Reply-To: <20190211084714.nq3wqxk66dbrfqvy@vireshk-i7>
On Mon, Feb 11, 2019 at 02:17:14PM +0530, Viresh Kumar wrote:
> On 08-02-19, 17:41, Sudeep Holla wrote:
> > Based on Rafael's suggestion, I cooked up something. See if this helps ?
> > The policy to cpu dance can be removed and we can just run through the
> > online cpumask I think.
> >
> > Regards,
> > Sudeep
> >
> > -->8
> >
> > diff --git i/drivers/cpufreq/cpufreq.c w/drivers/cpufreq/cpufreq.c
> > index e35a886e00bc..03d65a02a542 100644
> > --- i/drivers/cpufreq/cpufreq.c
> > +++ w/drivers/cpufreq/cpufreq.c
> > @@ -1640,6 +1640,7 @@ EXPORT_SYMBOL(cpufreq_generic_suspend);
> > void cpufreq_suspend(void)
> > {
> > struct cpufreq_policy *policy;
> > + int cpu;
> >
> > if (!cpufreq_driver)
> > return;
> > @@ -1662,6 +1663,11 @@ void cpufreq_suspend(void)
> > }
> >
> > suspend:
> > + if (cpufreq_driver->flags & CPUFREQ_DEFER_INIT_DURING_RESUME)
> > + for_each_active_policy(policy)
> > + for_each_cpu(cpu, policy->cpus)
> > + cpufreq_offline(cpu);
>
> You will offline boot-cpu as well :)
>
Indeed, I was just trying to check the idea of flags and clearly missed
the boot cpu :(
[..]
> > @@ -2444,14 +2455,16 @@ static enum cpuhp_state hp_online;
> >
> > static int cpuhp_cpufreq_online(unsigned int cpu)
> > {
> > - cpufreq_online(cpu);
> > + if (!(cpufreq_driver->flags & CPUFREQ_DEFER_INIT_DURING_RESUME))
> > + cpufreq_online(cpu);
>
> This isn't correct as we can offline the CPUs without suspend as well
> and cpufreq_online/offline should always be called in such cases.
>
Understood
> Anyways, I have cc'd you on another series which may end up fixing
> this problem as well.
Sure, will have a look.
--
Regards,
Sudeep
next prev parent reply other threads:[~2019-02-11 14:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190207122255eucas1p1cdebed838c799eca46cce6a654a26187@eucas1p1.samsung.com>
2019-02-07 12:22 ` [PATCH 0/2] cpufreq/opp: rework regulator initialization Marek Szyprowski
[not found] ` <CGME20190207122255eucas1p1444023f01217a43cfb958fe0bd48ef4d@eucas1p1.samsung.com>
2019-02-07 12:22 ` [PATCH 1/2] cpufreq: dt/ti/opp: move regulators initialization to the drivers Marek Szyprowski
[not found] ` <CGME20190207122256eucas1p17e8742176bda911263d2d14d2797a886@eucas1p1.samsung.com>
2019-02-07 12:22 ` [PATCH 2/2] cpufreq: dt: rework resources initialization Marek Szyprowski
2019-02-08 1:26 ` kbuild test robot
2019-02-08 6:49 ` [PATCH 0/2] cpufreq/opp: rework regulator initialization Viresh Kumar
2019-02-08 8:12 ` Marek Szyprowski
2019-02-08 8:55 ` Viresh Kumar
2019-02-08 9:15 ` Marek Szyprowski
2019-02-08 9:23 ` Viresh Kumar
2019-02-08 10:02 ` Marek Szyprowski
2019-02-08 10:08 ` Rafael J. Wysocki
2019-02-08 10:18 ` Rafael J. Wysocki
2019-02-08 10:28 ` Viresh Kumar
2019-02-08 10:22 ` Rafael J. Wysocki
2019-02-08 10:31 ` Marek Szyprowski
2019-02-08 10:31 ` Viresh Kumar
2019-02-08 10:42 ` Rafael J. Wysocki
2019-02-08 10:52 ` Rafael J. Wysocki
2019-02-08 11:39 ` Sudeep Holla
2019-02-08 12:03 ` Rafael J. Wysocki
2019-02-08 12:09 ` Sudeep Holla
2019-02-08 12:23 ` Rafael J. Wysocki
2019-02-08 14:28 ` Sudeep Holla
2019-02-08 11:00 ` Sudeep Holla
2019-02-08 11:47 ` Marek Szyprowski
2019-02-08 11:51 ` Sudeep Holla
2019-02-08 12:04 ` Marek Szyprowski
2019-02-08 12:11 ` Rafael J. Wysocki
2019-02-08 12:16 ` Sudeep Holla
2019-02-08 17:41 ` Sudeep Holla
2019-02-11 8:47 ` Viresh Kumar
2019-02-11 14:08 ` Sudeep Holla [this message]
2019-02-11 8:44 ` Viresh Kumar
2019-02-11 9:52 ` Marek Szyprowski
2019-02-11 9:55 ` Viresh Kumar
2019-02-11 12:22 ` Marek Szyprowski
2019-02-12 5:08 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211140829.GA4269@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=b.zolnierkie@samsung.com \
--cc=d-gerlach@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).