From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4C83C169C4 for ; Mon, 11 Feb 2019 14:58:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85CCB222A1 for ; Mon, 11 Feb 2019 14:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549897106; bh=OlU2JJltDBM+N2+6Sag/5GlCAX4SxFjJ/3yOni+hikI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gfaaRtloPHQGw6FAqjDi3z2sc+XGs7iJn8W+w3WRL53sacyWrWJATQTkG94ZDjPMv RcV07x0nT8J+aRcGuetqxtK90OWOe1O6zlnwa0nPfz29XUoUTbfbgK9fbCXqo/oYao kDPgsVlXi/59e9LT5U39oM3Hg1jyl0bXq4nsMdxY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389540AbfBKO6Y (ORCPT ); Mon, 11 Feb 2019 09:58:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:45992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389525AbfBKO6X (ORCPT ); Mon, 11 Feb 2019 09:58:23 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A10292229E; Mon, 11 Feb 2019 14:58:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549897102; bh=OlU2JJltDBM+N2+6Sag/5GlCAX4SxFjJ/3yOni+hikI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wc02HO00tTg0rf0sOiJAqkYMlbzNUyMu2YR0ZMXDfB3Hfm90kYxfH00+va27M7WvB SJtcYJ8Yag+T2oFeiIDDhV5X64uDZybGpI0zno/xvsgNW8W1GsDe34TuMyYLYrwGgP OjqAlIdYc+G/hWaC0izHrXjiP5hCrMt03XjRFE9Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yangtao Li , Daniel Lezcano , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 4.14 084/205] cpuidle: big.LITTLE: fix refcount leak Date: Mon, 11 Feb 2019 15:18:02 +0100 Message-Id: <20190211141834.189259844@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141827.214852402@linuxfoundation.org> References: <20190211141827.214852402@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 9456823c842f346c74265fcd98d008d87a7eb6f5 ] of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init() doesn't do that, so fix it. Signed-off-by: Yangtao Li Acked-by: Daniel Lezcano Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/cpuidle/cpuidle-big_little.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c index db2ede565f1a..b44476a1b7ad 100644 --- a/drivers/cpuidle/cpuidle-big_little.c +++ b/drivers/cpuidle/cpuidle-big_little.c @@ -167,6 +167,7 @@ static int __init bl_idle_init(void) { int ret; struct device_node *root = of_find_node_by_path("/"); + const struct of_device_id *match_id; if (!root) return -ENODEV; @@ -174,7 +175,11 @@ static int __init bl_idle_init(void) /* * Initialize the driver just for a compliant set of machines */ - if (!of_match_node(compatible_machine_match, root)) + match_id = of_match_node(compatible_machine_match, root); + + of_node_put(root); + + if (!match_id) return -ENODEV; if (!mcpm_is_available()) -- 2.19.1