From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2529EC169C4 for ; Mon, 11 Feb 2019 16:12:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD76720700 for ; Mon, 11 Feb 2019 16:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549901542; bh=OtqeTX0dvTwVTKlDl4YPvyYx0U5AVhCQ4FTUHB/D1ic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JFMoMnqG0S/y0cippp/CO0Cz6+k/5toXvmopjwhx6RbLjCuQ810nJFJLrnmHcdRYu LX2KKTMxI6fx7gl+dWsQp6PP2Lc8g7wCK2RK5hFObeyxt/liDznvLdOqIyZ836cGFK WEn90t6eCOVN3QTH1jh1i4Xb8D/qXRbG88odv6CE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729484AbfBKQMU (ORCPT ); Mon, 11 Feb 2019 11:12:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:56288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727916AbfBKOXQ (ORCPT ); Mon, 11 Feb 2019 09:23:16 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D1D320844; Mon, 11 Feb 2019 14:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549894995; bh=OtqeTX0dvTwVTKlDl4YPvyYx0U5AVhCQ4FTUHB/D1ic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PO28vPtqzgdPYYQHcpoZWNQm1l2hHhM16qGDcpYv7TP4szREUxBKE+DPACX7ev8Ye 5Pil8KTnuH/iOxmdyPQqzrfjUqRl/9O4ZoAX21w4GYY42RsfQ8OpCEtRCaXLMFdFse Ar9swWmVZ00mkqnuvLNUZB1Lty8HOIufXNov4jjQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.20 057/352] media: rc: ensure close() is called on rc_unregister_device Date: Mon, 11 Feb 2019 15:14:44 +0100 Message-Id: <20190211141849.795974357@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141846.543045703@linuxfoundation.org> References: <20190211141846.543045703@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 8e782fcf78275f505194e767c515202d4fd274bc ] If userspace has an open file descriptor on the rc input device or lirc device when rc_unregister_device() is called, then the rc close() is never called. This ensures that the receiver is turned off on the nuvoton-cir driver during shutdown. Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/rc/rc-main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 877978dbd409..66a174979b3c 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -1952,6 +1952,8 @@ void rc_unregister_device(struct rc_dev *dev) rc_free_rx_device(dev); mutex_lock(&dev->lock); + if (dev->users && dev->close) + dev->close(dev); dev->registered = false; mutex_unlock(&dev->lock); -- 2.19.1