From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7006C169C4 for ; Mon, 11 Feb 2019 14:26:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BF8D20821 for ; Mon, 11 Feb 2019 14:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549895201; bh=eC0Um43x+3htIXD9TVVZWIIoO/Nz5K+hgMH/jZEIjXA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iMDT1uFijXzDZEvaG1x39D/XhF3rhA7bmXT+Fj+3UqLSjku9/VvFpLDuRq7UIaZ50 P2v34ZE0Y6T+w0CRlSWI88IPCj5a9ZkgVafwl/1hDFxka/mF69cjOWNmcy5d6B4so/ eBTxklvRNZFxLPvM1NkDruZlvHU+P8Ea9LBrAQ80= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729590AbfBKO0k (ORCPT ); Mon, 11 Feb 2019 09:26:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:60476 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728219AbfBKO0h (ORCPT ); Mon, 11 Feb 2019 09:26:37 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B804720844; Mon, 11 Feb 2019 14:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549895196; bh=eC0Um43x+3htIXD9TVVZWIIoO/Nz5K+hgMH/jZEIjXA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D39yteMcGdm4Kd0X5ZSh1ILi1QOAjV+gipGKG20viSX7So0a5TRCtRGOLkurmbP9g JryCB+vzVHZ2dVjU7P3z4W3XHIDjBVP2m6KH+6kK6+z7qC8KDACT1GirO7AqsFl5QD XH6mRZazG0Ay/CQx38OLWx5Mk5Pc+i5yIWFivhHg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felipe Balbi , Andy Shevchenko , Sasha Levin Subject: [PATCH 4.20 126/352] usb: dwc3: trace: add missing break statement to make compiler happy Date: Mon, 11 Feb 2019 15:15:53 +0100 Message-Id: <20190211141854.361927217@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141846.543045703@linuxfoundation.org> References: <20190211141846.543045703@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 54d48183d21e03f780053d7129312049cb5dd591 ] The missed break statement in the outer switch makes the code fall through always and thus always same value will be printed. Besides that, compiler warns about missed fall through marker: drivers/usb/dwc3/./trace.h: In function ‘trace_raw_output_dwc3_log_trb’: drivers/usb/dwc3/./trace.h:246:4: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (pcm) { ^~~~~~ Add the missing break statement to work correctly without compilation warnings. Fixes: fa8d965d736b ("usb: dwc3: trace: pretty print high-bandwidth transfers too") Cc: Felipe Balbi Signed-off-by: Andy Shevchenko Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/dwc3/trace.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h index f22714cce070..f27c5cbe285c 100644 --- a/drivers/usb/dwc3/trace.h +++ b/drivers/usb/dwc3/trace.h @@ -251,9 +251,11 @@ DECLARE_EVENT_CLASS(dwc3_log_trb, s = "2x "; break; case 3: + default: s = "3x "; break; } + break; default: s = ""; } s; }), -- 2.19.1