From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0437C282CE for ; Mon, 11 Feb 2019 16:20:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B080F21B24 for ; Mon, 11 Feb 2019 16:20:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728658AbfBKQUG (ORCPT ); Mon, 11 Feb 2019 11:20:06 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:53554 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727224AbfBKQUF (ORCPT ); Mon, 11 Feb 2019 11:20:05 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 237D380D; Mon, 11 Feb 2019 08:20:05 -0800 (PST) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1064D3F675; Mon, 11 Feb 2019 08:20:02 -0800 (PST) Date: Mon, 11 Feb 2019 16:19:57 +0000 From: Lorenzo Pieralisi To: Wen Yang Cc: kishon@ti.com, bhelgaas@google.com, gustavo.pimentel@synopsys.com, niklas.cassel@axis.com, baijiaju1990@gmail.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn, wang.yi59@zte.com.cn, Greg Kroah-Hartman , Cyrille Pitchen Subject: Re: [PATCH] PCI: endpoint: functions: use memcpy_fromio()/memcpy_toio() Message-ID: <20190211161957.GA27797@e107981-ln.cambridge.arm.com> References: <1549875840-10582-1-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1549875840-10582-1-git-send-email-wen.yang99@zte.com.cn> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 11, 2019 at 05:04:00PM +0800, Wen Yang wrote: > Use the IO memcpy() functions when copying from/to IO memory. > These locations were found via sparse. > > Signed-off-by: Wen Yang > Suggested-by: Kishon Vijay Abraham I > CC: Lorenzo Pieralisi > CC: Bjorn Helgaas > CC: Gustavo Pimentel > CC: Niklas Cassel > CC: Greg Kroah-Hartman > CC: Cyrille Pitchen > CC: linux-pci@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > drivers/pci/endpoint/functions/pci-epf-test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, with updated tags to pci/endpoint for v5.1, thanks. Lorenzo > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index 3e86fa3..4bbd26e 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -175,7 +175,7 @@ static int pci_epf_test_read(struct pci_epf_test *epf_test) > goto err_map_addr; > } > > - memcpy(buf, src_addr, reg->size); > + memcpy_fromio(buf, src_addr, reg->size); > > crc32 = crc32_le(~0, buf, reg->size); > if (crc32 != reg->checksum) > @@ -230,7 +230,7 @@ static int pci_epf_test_write(struct pci_epf_test *epf_test) > get_random_bytes(buf, reg->size); > reg->checksum = crc32_le(~0, buf, reg->size); > > - memcpy(dst_addr, buf, reg->size); > + memcpy_toio(dst_addr, buf, reg->size); > > /* > * wait 1ms inorder for the write to complete. Without this delay L3 > -- > 2.9.5 >