* [PATCH 2/3] nvmem: imx-ocotp: add support for imx8mq
2019-02-11 16:50 [PATCH 1/3] dt-bindings: imx-ocotp: Add i.MX8MQ compatible Lucas Stach
@ 2019-02-11 16:50 ` Lucas Stach
2019-02-11 16:50 ` [PATCH 3/3] nvmem: imx-ocotp: broaden Kconfig dependency Lucas Stach
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Lucas Stach @ 2019-02-11 16:50 UTC (permalink / raw)
To: Srinivas Kandagatla, Rob Herring
Cc: devicetree, linux-kernel, Carlo Caione, linux-imx, kernel, patchwork-lst
The i.MX8MQ uses the same OCOTP block as the i.MX7D, but with
fourfold increase in fuse banks.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/nvmem/imx-ocotp.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
index afb429a417fe..bcae2aed75ad 100644
--- a/drivers/nvmem/imx-ocotp.c
+++ b/drivers/nvmem/imx-ocotp.c
@@ -433,6 +433,12 @@ static const struct ocotp_params imx7d_params = {
.set_timing = imx_ocotp_set_imx7_timing,
};
+static const struct ocotp_params imx8mq_params = {
+ .nregs = 256,
+ .bank_address_words = 4,
+ .set_timing = imx_ocotp_set_imx7_timing,
+};
+
static const struct of_device_id imx_ocotp_dt_ids[] = {
{ .compatible = "fsl,imx6q-ocotp", .data = &imx6q_params },
{ .compatible = "fsl,imx6sl-ocotp", .data = &imx6sl_params },
@@ -440,6 +446,7 @@ static const struct of_device_id imx_ocotp_dt_ids[] = {
{ .compatible = "fsl,imx6ul-ocotp", .data = &imx6ul_params },
{ .compatible = "fsl,imx7d-ocotp", .data = &imx7d_params },
{ .compatible = "fsl,imx6sll-ocotp", .data = &imx6sll_params },
+ { .compatible = "fsl,imx8mq-ocotp", .data = &imx8mq_params },
{ },
};
MODULE_DEVICE_TABLE(of, imx_ocotp_dt_ids);
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/3] nvmem: imx-ocotp: broaden Kconfig dependency
2019-02-11 16:50 [PATCH 1/3] dt-bindings: imx-ocotp: Add i.MX8MQ compatible Lucas Stach
2019-02-11 16:50 ` [PATCH 2/3] nvmem: imx-ocotp: add support for imx8mq Lucas Stach
@ 2019-02-11 16:50 ` Lucas Stach
2019-02-12 9:57 ` [PATCH 1/3] dt-bindings: imx-ocotp: Add i.MX8MQ compatible Abel Vesa
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Lucas Stach @ 2019-02-11 16:50 UTC (permalink / raw)
To: Srinivas Kandagatla, Rob Herring
Cc: devicetree, linux-kernel, Carlo Caione, linux-imx, kernel, patchwork-lst
The i.MX OCOTP controller is used in numerous Freescale/NXP
SoCs from the MXC family, so the strict dependency on the
i.MX6 SoC is too narrow. Broaden it to cover all the MXC
familiy members.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/nvmem/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 0a7a470ee859..665f2494095a 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -25,8 +25,8 @@ config NVMEM_IMX_IIM
will be called nvmem-imx-iim.
config NVMEM_IMX_OCOTP
- tristate "i.MX6 On-Chip OTP Controller support"
- depends on SOC_IMX6 || COMPILE_TEST
+ tristate "i.MX 6/7/8 On-Chip OTP Controller support"
+ depends on ARCH_MXC || COMPILE_TEST
depends on HAS_IOMEM
help
This is a driver for the On-Chip OTP Controller (OCOTP) available on
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] dt-bindings: imx-ocotp: Add i.MX8MQ compatible
2019-02-11 16:50 [PATCH 1/3] dt-bindings: imx-ocotp: Add i.MX8MQ compatible Lucas Stach
2019-02-11 16:50 ` [PATCH 2/3] nvmem: imx-ocotp: add support for imx8mq Lucas Stach
2019-02-11 16:50 ` [PATCH 3/3] nvmem: imx-ocotp: broaden Kconfig dependency Lucas Stach
@ 2019-02-12 9:57 ` Abel Vesa
2019-02-25 23:34 ` Rob Herring
2019-02-26 9:04 ` Abel Vesa
4 siblings, 0 replies; 6+ messages in thread
From: Abel Vesa @ 2019-02-12 9:57 UTC (permalink / raw)
To: Lucas Stach
Cc: Srinivas Kandagatla, Rob Herring, devicetree, linux-kernel,
Carlo Caione, dl-linux-imx, kernel, patchwork-lst
On 19-02-11 17:50:09, Lucas Stach wrote:
> Add compatible for i.MX8MQ and add both i.MX7D/S and i.M8MQ
> to the description.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> index 792bc5fafeb9..bb8fb8fc6217 100644
> --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> @@ -1,7 +1,8 @@
> Freescale i.MX6 On-Chip OTP Controller (OCOTP) device tree bindings
>
> This binding represents the on-chip eFuse OTP controller found on
> -i.MX6Q/D, i.MX6DL/S, i.MX6SL, i.MX6SX, i.MX6UL and i.MX6SLL SoCs.
> +i.MX6Q/D, i.MX6DL/S, i.MX6SL, i.MX6SX, i.MX6UL, i.MX6SLL, i.MX7D/S
> +and i.MX8MQ SoCs.
>
> Required properties:
> - compatible: should be one of
> @@ -11,6 +12,7 @@ Required properties:
> "fsl,imx6ul-ocotp" (i.MX6UL),
> "fsl,imx7d-ocotp" (i.MX7D/S),
> "fsl,imx6sll-ocotp" (i.MX6SLL),
> + "fsl,imx8mq-ocotp" (i.MX8MQ),
> followed by "syscon".
> - #address-cells : Should be 1
> - #size-cells : Should be 1
> --
> 2.20.1
>
The entire series looks good to me.
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] dt-bindings: imx-ocotp: Add i.MX8MQ compatible
2019-02-11 16:50 [PATCH 1/3] dt-bindings: imx-ocotp: Add i.MX8MQ compatible Lucas Stach
` (2 preceding siblings ...)
2019-02-12 9:57 ` [PATCH 1/3] dt-bindings: imx-ocotp: Add i.MX8MQ compatible Abel Vesa
@ 2019-02-25 23:34 ` Rob Herring
2019-02-26 9:04 ` Abel Vesa
4 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2019-02-25 23:34 UTC (permalink / raw)
To: Lucas Stach
Cc: Srinivas Kandagatla, devicetree, linux-kernel, Carlo Caione,
linux-imx, kernel, patchwork-lst
On Mon, 11 Feb 2019 17:50:09 +0100, Lucas Stach wrote:
> Add compatible for i.MX8MQ and add both i.MX7D/S and i.M8MQ
> to the description.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] dt-bindings: imx-ocotp: Add i.MX8MQ compatible
2019-02-11 16:50 [PATCH 1/3] dt-bindings: imx-ocotp: Add i.MX8MQ compatible Lucas Stach
` (3 preceding siblings ...)
2019-02-25 23:34 ` Rob Herring
@ 2019-02-26 9:04 ` Abel Vesa
4 siblings, 0 replies; 6+ messages in thread
From: Abel Vesa @ 2019-02-26 9:04 UTC (permalink / raw)
To: Lucas Stach
Cc: Srinivas Kandagatla, Rob Herring, devicetree, linux-kernel,
Carlo Caione, dl-linux-imx, kernel, patchwork-lst
On 19-02-11 17:50:09, Lucas Stach wrote:
> Add compatible for i.MX8MQ and add both i.MX7D/S and i.M8MQ
> to the description.
Hi Lucas,
This patchset does not apply on linux-next anymore due to the new additions
in the compatible lists (imx6ull/imx6ulz) in imx-ocotp.
Can you please resend ?
Thanks,
Abel
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> index 792bc5fafeb9..bb8fb8fc6217 100644
> --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> @@ -1,7 +1,8 @@
> Freescale i.MX6 On-Chip OTP Controller (OCOTP) device tree bindings
>
> This binding represents the on-chip eFuse OTP controller found on
> -i.MX6Q/D, i.MX6DL/S, i.MX6SL, i.MX6SX, i.MX6UL and i.MX6SLL SoCs.
> +i.MX6Q/D, i.MX6DL/S, i.MX6SL, i.MX6SX, i.MX6UL, i.MX6SLL, i.MX7D/S
> +and i.MX8MQ SoCs.
>
> Required properties:
> - compatible: should be one of
> @@ -11,6 +12,7 @@ Required properties:
> "fsl,imx6ul-ocotp" (i.MX6UL),
> "fsl,imx7d-ocotp" (i.MX7D/S),
> "fsl,imx6sll-ocotp" (i.MX6SLL),
> + "fsl,imx8mq-ocotp" (i.MX8MQ),
> followed by "syscon".
> - #address-cells : Should be 1
> - #size-cells : Should be 1
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread