From: Luis Chamberlain <mcgrof@kernel.org>
To: Greg KH <greg@kroah.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the driver-core tree
Date: Mon, 11 Feb 2019 09:10:47 -0800 [thread overview]
Message-ID: <20190211171047.GN11489@garbanzo.do-not-panic.com> (raw)
In-Reply-To: <20190211074402.GA7356@kroah.com>
On Mon, Feb 11, 2019 at 08:44:02AM +0100, Greg KH wrote:
> On Mon, Feb 11, 2019 at 07:40:52AM +1100, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > In commit
> >
> > 344c0152d878 ("selftests: firmware: fix verify_reqs() return value")
> >
> > Fixes tag
> >
> > Fixes: a6a9be9270c87 ("selftests: firmware: return Kselftest Skip code for for skipped tests")
> >
> > has these problem(s):
> >
> > - Subject does not match target commit subject
>
> I don't understand, what is wrong with the fixes: tag here?
>
> $ git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" a6a9be9270c87
> a6a9be9270c8 ("selftests: firmware: return Kselftest Skip code for skipped tests")
>
> How does that not match up?
>
> Ah, an extra "for" in there. Luis, you need to fix up your scripts, and
> not be forced to manually type in those lines :)
Will do.
Luis
prev parent reply other threads:[~2019-02-11 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 20:40 linux-next: Fixes tag needs some work in the driver-core tree Stephen Rothwell
2019-02-11 7:44 ` Greg KH
2019-02-11 17:10 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211171047.GN11489@garbanzo.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).