LKML Archive on lore.kernel.org
 help / Atom feed
* linux-next: Fixes tag needs some work in the driver-core tree
@ 2019-02-10 20:40 Stephen Rothwell
  2019-02-11  7:44 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2019-02-10 20:40 UTC (permalink / raw)
  To: Greg KH
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Luis Chamberlain

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

Hi Greg,

In commit

  344c0152d878 ("selftests: firmware: fix verify_reqs() return value")

Fixes tag

  Fixes: a6a9be9270c87 ("selftests: firmware: return Kselftest Skip code for for skipped tests")

has these problem(s):

  - Subject does not match target commit subject

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: Fixes tag needs some work in the driver-core tree
  2019-02-10 20:40 linux-next: Fixes tag needs some work in the driver-core tree Stephen Rothwell
@ 2019-02-11  7:44 ` Greg KH
  2019-02-11 17:10   ` Luis Chamberlain
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-02-11  7:44 UTC (permalink / raw)
  To: Stephen Rothwell, Luis Chamberlain
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On Mon, Feb 11, 2019 at 07:40:52AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> In commit
> 
>   344c0152d878 ("selftests: firmware: fix verify_reqs() return value")
> 
> Fixes tag
> 
>   Fixes: a6a9be9270c87 ("selftests: firmware: return Kselftest Skip code for for skipped tests")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject

I don't understand, what is wrong with the fixes: tag here?

$ git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" a6a9be9270c87
a6a9be9270c8 ("selftests: firmware: return Kselftest Skip code for skipped tests")

How does that not match up?

Ah, an extra "for" in there.  Luis, you need to fix up your scripts, and
not be forced to manually type in those lines :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: Fixes tag needs some work in the driver-core tree
  2019-02-11  7:44 ` Greg KH
@ 2019-02-11 17:10   ` Luis Chamberlain
  0 siblings, 0 replies; 3+ messages in thread
From: Luis Chamberlain @ 2019-02-11 17:10 UTC (permalink / raw)
  To: Greg KH
  Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List

On Mon, Feb 11, 2019 at 08:44:02AM +0100, Greg KH wrote:
> On Mon, Feb 11, 2019 at 07:40:52AM +1100, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > In commit
> > 
> >   344c0152d878 ("selftests: firmware: fix verify_reqs() return value")
> > 
> > Fixes tag
> > 
> >   Fixes: a6a9be9270c87 ("selftests: firmware: return Kselftest Skip code for for skipped tests")
> > 
> > has these problem(s):
> > 
> >   - Subject does not match target commit subject
> 
> I don't understand, what is wrong with the fixes: tag here?
> 
> $ git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" a6a9be9270c87
> a6a9be9270c8 ("selftests: firmware: return Kselftest Skip code for skipped tests")
> 
> How does that not match up?
> 
> Ah, an extra "for" in there.  Luis, you need to fix up your scripts, and
> not be forced to manually type in those lines :)

Will do.

  Luis

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-10 20:40 linux-next: Fixes tag needs some work in the driver-core tree Stephen Rothwell
2019-02-11  7:44 ` Greg KH
2019-02-11 17:10   ` Luis Chamberlain

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox