From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: RFC: drop ISA support in the synlink tty driver?
Date: Tue, 12 Feb 2019 09:25:17 +0100 [thread overview]
Message-ID: <20190212082517.GA27889@kroah.com> (raw)
In-Reply-To: <7585c8b6-6dc4-2556-d14f-2fd60dc7df90@suse.cz>
On Tue, Feb 12, 2019 at 09:08:41AM +0100, Jiri Slaby wrote:
> On 12. 02. 19, 8:51, Greg Kroah-Hartman wrote:
> > On Mon, Feb 11, 2019 at 02:25:33PM +0100, Christoph Hellwig wrote:
> >> Hi Greg and Jiri,
> >>
> >> I've been working hard to get rid of the remaining callers the pass a
> >> NULL struct device to the DMA mapping functions and am almost done.
> >>
> >> The only non-trivial driver is the synclink driver, which has legacy
> >> early 90s style ISA support that doesn't use the device model at all.
> >>
> >> In theory we could convert it to an isa_driver, but without testing
> >> that seems rather dangerous. So for now I would suggest that we
> >> remove the ISA support in this driver - if anyone cares enough we
> >> can resurrect it from the git history and convert it to use the driver
> >> model.
> >
> > No objection from me at all, I'll go queue this up now, thanks.
>
> Agreed, but I would kill also the MGSL_BUS_TYPE_ISA macro proper.
It's just a #define, in a uapi file, so we should probably leave it as
userspace programs _might_ depend on it. I have no idea why, but oh
well...
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-12 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 13:25 RFC: drop ISA support in the synlink tty driver? Christoph Hellwig
2019-02-11 13:25 ` [PATCH] tty/synclink: remove ISA support Christoph Hellwig
2019-02-12 7:51 ` RFC: drop ISA support in the synlink tty driver? Greg Kroah-Hartman
2019-02-12 8:08 ` Jiri Slaby
2019-02-12 8:25 ` Greg Kroah-Hartman [this message]
2019-02-12 8:40 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212082517.GA27889@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).