From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFBB7C282C4 for ; Tue, 12 Feb 2019 12:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C05C62075D for ; Tue, 12 Feb 2019 12:07:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728788AbfBLMHq (ORCPT ); Tue, 12 Feb 2019 07:07:46 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35748 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726026AbfBLMHp (ORCPT ); Tue, 12 Feb 2019 07:07:45 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 5A10380442; Tue, 12 Feb 2019 13:07:36 +0100 (CET) Date: Tue, 12 Feb 2019 13:07:42 +0100 From: Pavel Machek To: Bartosz Golaszewski Cc: Rob Herring , Mark Rutland , Linus Walleij , Dmitry Torokhov , Jacek Anaszewski , Lee Jones , Sebastian Reichel , Liam Girdwood , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v3 07/11] power: supply: max77650: add support for battery charger Message-ID: <20190212120742.GA25613@amd> References: <20190201094736.32057-1-brgl@bgdev.pl> <20190201094736.32057-8-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9amGYk9869ThD9tj" Content-Disposition: inline In-Reply-To: <20190201094736.32057-8-brgl@bgdev.pl> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --9amGYk9869ThD9tj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > +#define MAX77650_CHARGER_ENABLED BIT(0) > +#define MAX77650_CHARGER_DISABLED 0x00 > +#define MAX77650_CHARGER_CHG_EN_MASK BIT(0) > + > +#define MAX77650_CHARGER_CHG_DTLS_MASK GENMASK(7, 4) > +#define MAX77650_CHARGER_CHG_DTLS_BITS(_reg) \ > + (((_reg) & MAX77650_CHARGER_CHG_DTLS_MASK) >> 4) > + > +#define MAX77650_CHARGER_CHG_OFF 0x00 > +#define MAX77650_CHARGER_CHG_PREQ 0x01 > +#define MAX77650_CHARGER_CHG_ON_CURR 0x02 > +#define MAX77650_CHARGER_CHG_ON_JCURR 0x03 > +#define MAX77650_CHARGER_CHG_ON_VOLT 0x04 > +#define MAX77650_CHARGER_CHG_ON_JVOLT 0x05 > +#define MAX77650_CHARGER_CHG_ON_TOPOFF 0x06 > +#define MAX77650_CHARGER_CHG_ON_JTOPOFF 0x07 > +#define MAX77650_CHARGER_CHG_DONE 0x08 > +#define MAX77650_CHARGER_CHG_JDONE 0x09 > +#define MAX77650_CHARGER_CHG_SUSP_PF 0x0a > +#define MAX77650_CHARGER_CHG_SUSP_FCF 0x0b > +#define MAX77650_CHARGER_CHG_SUSP_BTF 0x0c These are really bad define names. We are in charger driver, so MAX77650_CHARGER_ really should be shortened/ommited. OTOH more space should be given to "CHG_SUSP_BTF" as it is impossible to deciphe= r. > +#define MAX77650_CHARGER_CHGIN_DTLS_MASK GENMASK(3, 2) > +#define MAX77650_CHARGER_CHGIN_DTLS_BITS(_reg) \ > + (((_reg) & MAX77650_CHARGER_CHGIN_DTLS_MASK) >> 2) > + > +#define MAX77650_CHARGER_CHGIN_UVL 0x00 > +#define MAX77650_CHARGER_CHGIN_OVL 0x01 > +#define MAX77650_CHARGER_CHGIN_OKAY 0x11 UVL -> UNDERVOLTAGE, OVL -> OVERVOLTAGE? --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --9amGYk9869ThD9tj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlxitw4ACgkQMOfwapXb+vJeWACgsckI6u+OjVG14U//9pRVbij1 yksAn1012uzNOYXdBfQzs1yA66em9hGj =fkry -----END PGP SIGNATURE----- --9amGYk9869ThD9tj--