linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"Tobin C . Harding" <me@tobin.cc>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@suse.cz>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 5/9] vsprintf: Factor out %pV handler as va_format()
Date: Tue, 12 Feb 2019 14:00:30 +0100	[thread overview]
Message-ID: <20190212130030.s22aamlnmj2lv7zg@pathway.suse.cz> (raw)
In-Reply-To: <f308ab312810d538a79c2f54f49edba32c60b561.camel@perches.com>

On Fri 2019-02-08 09:11:17, Joe Perches wrote:
> On Fri, 2019-02-08 at 16:23 +0100, Petr Mladek wrote:
> > Move the code from the long pointer() function. We are going to improve
> > error handling that will make it more complicated.
> > 
> > This patch does not change the existing behavior.
> 
> But doesn't this increase stack use?
> %pV is recursive and increasing the stack is undesired
> for this use.

%pV handler is stack sensitive because the entire vsnprintf()
machinery is called recursively. This one extra call does
not make it much worse.

Best Regards,
Petr

  reply	other threads:[~2019-02-12 13:00 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 15:23 [PATCH v6 0/9] vsprintf: Prevent silent crashes and consolidate error handling Petr Mladek
2019-02-08 15:23 ` [PATCH v6 1/9] vsprintf: Shuffle restricted_pointer() Petr Mladek
2019-02-08 15:23 ` [PATCH v6 2/9] vsprintf: Consistent %pK handling for kptr_restrict == 0 Petr Mladek
2019-02-08 15:23 ` [PATCH v6 3/9] vsprintf: Do not check address of well-known strings Petr Mladek
2019-02-08 17:27   ` Andy Shevchenko
2019-02-08 15:23 ` [PATCH v6 4/9] vsprintf: Factor out %p[iI] handler as ip_addr_string() Petr Mladek
2019-02-08 15:23 ` [PATCH v6 5/9] vsprintf: Factor out %pV handler as va_format() Petr Mladek
2019-02-08 17:11   ` Joe Perches
2019-02-12 13:00     ` Petr Mladek [this message]
2019-02-12 14:32       ` Steven Rostedt
2019-02-12 17:58       ` Joe Perches
2019-02-12 19:47         ` Steven Rostedt
2019-02-12 20:22         ` Rasmus Villemoes
2019-02-08 15:23 ` [PATCH v6 6/9] vsprintf: Factor out %pO handler as kobject_string() Petr Mladek
2019-02-08 15:23 ` [PATCH v6 7/9] vsprintf: Consolidate handling of unknown pointer specifiers Petr Mladek
2019-02-08 17:25   ` Andy Shevchenko
2019-02-12 13:35     ` Petr Mladek
2019-02-08 15:23 ` [PATCH v6 8/9] vsprintf: Prevent crash when dereferencing invalid pointers Petr Mladek
2019-02-19  3:30   ` Sergey Senozhatsky
2019-02-19 11:02     ` Andy Shevchenko
2019-02-19 12:51       ` Sergey Senozhatsky
2019-02-19 13:49         ` Andy Shevchenko
2019-02-19 14:15           ` Sergey Senozhatsky
2019-02-20 10:24             ` Petr Mladek
2019-02-08 15:23 ` [PATCH v6 9/9] vsprintf: Avoid confusion between invalid address and value Petr Mladek
2019-02-08 17:27   ` Andy Shevchenko
2019-02-12 15:45     ` Petr Mladek
2019-02-13 13:54       ` Andy Shevchenko
2019-02-14  8:42         ` Petr Mladek
2019-02-14 12:45           ` Andy Shevchenko
2019-02-19  3:03   ` Sergey Senozhatsky
2019-02-19 11:06     ` Andy Shevchenko
2019-02-20  9:24       ` Petr Mladek
2019-02-21  1:47         ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190212130030.s22aamlnmj2lv7zg@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=me@tobin.cc \
    --cc=mhocko@suse.cz \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).